From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E940E42EF5C for ; Thu, 2 Jul 2020 13:08:01 +0300 (MSK) References: <20200702095054.367131-1-gorcunov@gmail.com> From: Oleg Babin Message-ID: Date: Thu, 2 Jul 2020 13:08:00 +0300 MIME-Version: 1.0 In-Reply-To: <20200702095054.367131-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter in boottime logger List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Cc: yaroslav.dynnikov@gmail.com Hi! LGTM for whole patchset except one note that I've sent separately for the second patch. On 02/07/2020 12:50, Cyrill Gorcunov wrote: > For some reason we've disabled usage of json formatter in early > logging since the commit 098324556. Lets allow it back. > > v2: > - add early verification of options for cases like > box.cfg{log="syslog:", log_format="json"} > - extend test > > v3: > - pass the whole cfg table into verify_option helper > - use string.startswith helper in verify_format > > branch gorcunov/gh-5121-logger-boot-json-3 > issue https://github.com/tarantool/tarantool/issues/5121 > > Cyrill Gorcunov (3): > core/say: allow to use json in boot logger > lua/log: allow to use json formatter early > test: app-tap/logger -- test json in boottime logger > > src/box/lua/load_cfg.lua | 6 +++--- > src/lib/core/say.c | 7 ++---- > src/lua/log.lua | 42 +++++++++++++++++++++++++++--------- > test/app-tap/logger.test.lua | 19 ++++++++++++---- > 4 files changed, 52 insertions(+), 22 deletions(-) >