From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7D218C634DE; Wed, 21 Aug 2024 19:27:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7D218C634DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724257670; bh=NzaYMy1U4WUTJPcyszGb10uhv1+9OEnZZxWHFe2BoOo=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xAto2ZgcHK6/5idtIoEhUt7uYdmNwdBXOisGOU2Ke052lq87MJMkZlOOf2gqsDx2t xRnvd4X9Mwgpanu3lgRpXGVTAJy9h4m4ishUuWsjStA65CXq8X2wsl1FBNKguD3jJU buqrev5xQM6p3RnSK8y1CDTCBbNr6oOLTUU6i4/0= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5163AC634D1 for ; Wed, 21 Aug 2024 19:27:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5163AC634D1 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1sgoBY-0000000C0mX-1lUY; Wed, 21 Aug 2024 19:27:48 +0300 Content-Type: multipart/alternative; boundary="------------0MgLss4as9iah9o8SzjFVX7A" Message-ID: Date: Wed, 21 Aug 2024 19:27:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9BB2AFC06FD50F0EFA3DEBF910ED49A72A2811999FD44BB87182A05F538085040105DEEAD8988DC8C0578E6996F383413F9EF62789B72DD550A1FCD11FCABB27A5E5D4A160AC272F4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370EBB47D88F71BB738638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80E8D3EED5A85651F6E6BFF6ECC316375C648C2FBF255A090CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063790495A4AD0498982D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE72B056A9979167638EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30A3B31C63366F72535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5E421C01697F286465002B1117B3ED6962E88C785BFC79797CCE9A60C8CB01D7C823CB91A9FED034534781492E4B8EEADB71243024C627CEABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34B0359B88B232A0C6F010122A6ADB21322C5F4A0AFA48221513C361B471B0472A584849E279418DE71D7E09C32AA3244C7F103EE4015E62BB4EB7DF677E51682D6BF0F16D688D7561EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojegttVMu7AX9aw/W2TDRKdg== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61409A50A107ECF52A744371F2AEFDCE2FD5FF8C368061F233320152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 05/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------0MgLss4as9iah9o8SzjFVX7A Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, again On 21.08.2024 19:20, Sergey Bronnikov via Tarantool-patches wrote: > > Sergey, > > On 21.08.2024 11:58, Sergey Kaplun wrote: >> This patch refactors the test by adding a simple >> check for the content of a `debug.traceback()` result. Also, the test is >> moved to the directory. >> >> Also, it removes the since it is the same test >> that wasn't cleaned up during the refactoring in the original >> repository. >> >> Part of tarantool/tarantool#9398 >> --- > > thanks for the patch! LGTM > > Please add a note to the top of the file that test is fragile > > and depends on a number of lines in the file. > Please disregard, is not defined as a constant number in the test. LGTM then. --------------0MgLss4as9iah9o8SzjFVX7A Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, again

On 21.08.2024 19:20, Sergey Bronnikov via Tarantool-patches wrote:

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch refactors the <lang/coroutine.lua> test by adding a simple
check for the content of a `debug.traceback()` result. Also, the test is
moved to the <lib/coroutine/> directory.

Also, it removes the <misc/coro_traceback.lua> since it is the same test
that wasn't cleaned up during the refactoring in the original
repository.

Part of tarantool/tarantool#9398
---

thanks for the patch! LGTM

Please add a note to the top of the file that test is fragile

and depends on a number of lines in the file.

Please disregard, <linedefined> is not defined as a constant number in the test.

LGTM then.

--------------0MgLss4as9iah9o8SzjFVX7A--