From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 65D239E55C0; Thu, 21 Mar 2024 11:33:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 65D239E55C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711010039; bh=anWrF545HU2Oz9+KyuttppLYyoHWt66YSlsaMjx9pik=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=SN+LTg5q+p2w1/VSS17pmbtGV8PCcOICRCf7U8zCvcbKgRUuYBAyfdEkUzab5XboG hpv4b4Nx38NOaAXkdUGRR/1T9XxWecXjW8TrZ8QbL49ZQwDGFlVGxDa+zC1qP1xCgg lCnkZMVwe5y6SFJRa8zojEpuCcTIFk8s+jAmUd2E= Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2747D9E55C0 for ; Thu, 21 Mar 2024 11:33:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2747D9E55C0 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2d687da75c4so8666571fa.0 for ; Thu, 21 Mar 2024 01:33:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711010037; x=1711614837; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jZ+BD5thslqJjbjS5sMVDNT3m1YMDrqXL3Xe2Fqvk/c=; b=AZLLKy6Iux//Vdr1evOAGe0qMG6XQ5IHGNtmXDq7zM6kCN0wcT7LER9zA97LVMC2jK rr8aj+y+6Nnp+QFpaxHksY49MmWGQwNd0bvg69x4riuSggr6MuXrQWs2rFLBK/qPbRmO DbU8gwgclXpJ8OKr4s4SL9DIVQqiKK4nuEn79HFoCiy/GCM4CrHljUKcPuh5caCoDNyk tSsK9p5ImOm+qQYhwKGxSlBQOYBNKiRwOmrehMskEUP79C1Ul/hT4D7Edy25OJQ2S5iP RUFKnbqu9+FeekceaWpYmEujFwwIIL1xZBLb0LykwT3jaNu7ok5UYoV1mVU0xJOtagSe inuQ== X-Gm-Message-State: AOJu0YzX7OcXdjoh00XoGTAOD24iBGzShpn2iOhWzXwbxTkJt+vesMsq m2ZpjBkgAre8TqmPPvQ3fRgRVQDPitJaxtWSUyVvCbfZIgfgQAsOo3sCQbpEaHA= X-Google-Smtp-Source: AGHT+IGAH5fPmUnFRn6F9gI8jRcMK37/dGR6oe8RXjXT+a13zc2367Psux2yRWv0fUIfLbOcQUX1eA== X-Received: by 2002:a2e:b0cf:0:b0:2d4:c9c4:cd52 with SMTP id g15-20020a2eb0cf000000b002d4c9c4cd52mr7174298ljl.33.1711010036827; Thu, 21 Mar 2024 01:33:56 -0700 (PDT) Received: from pony.. ([5.181.62.126]) by smtp.gmail.com with ESMTPSA id u22-20020a2e8456000000b002d51e0b73aesm1010649ljh.25.2024.03.21.01.33.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Mar 2024 01:33:55 -0700 (PDT) To: tarantool-patches@dev.tarantool.org, Sergey Kaplun , Maxim Kokryashkin Date: Thu, 21 Mar 2024 11:33:29 +0300 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH luajit] cmake: fix warnings about minimum required version X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Sergey Bronnikov CMake produces annoying warnings: CMake Deprecation Warning at src/CMakeLists.txt:7 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future version of CMake. We cannot bump a minimum required CMake version without bumping it in a Tarantool build system. However, we can set a max supported CMake version and suppress a warning. CMake 3.27.7 is a version used by me for a long time for building LuaJIT. This version is tested and seen no policy warnings with a that version. --- Branch: https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings Doc: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html NOTE: another solution is using CMAKE_WARN_DEPRECATED, but I don't like it. Let's discuss. 1. https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html CMakeLists.txt | 2 +- etc/CMakeLists.txt | 2 +- src/CMakeLists.txt | 2 +- src/host/CMakeLists.txt | 2 +- test/CMakeLists.txt | 2 +- test/LuaJIT-tests/CMakeLists.txt | 2 +- test/LuaJIT-tests/src/CMakeLists.txt | 2 +- test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt | 2 +- test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 2 +- test/lua-Harness-tests/CMakeLists.txt | 2 +- test/tarantool-tests/CMakeLists.txt | 2 +- tools/CMakeLists.txt | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7f5e2afb..9edff6f3 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -8,7 +8,7 @@ # --- Initial setup ------------------------------------------------------------ # See the rationale below (near LUAJIT_TEST_BINARY variable). -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) project(LuaJIT C) # XXX: Originally CMake machinery is introduced to make LuaJIT diff --git a/etc/CMakeLists.txt b/etc/CMakeLists.txt index d54fa794..39f6df77 100644 --- a/etc/CMakeLists.txt +++ b/etc/CMakeLists.txt @@ -1,7 +1,7 @@ # Building supplementary materials for LuaJIT. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) set(LUAJIT_PC_PREFIX ${CMAKE_INSTALL_PREFIX}) if(CMAKE_LIBRARY_ARCHITECTURE) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 03338306..be11dde6 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -4,7 +4,7 @@ # Copyright (C) 2015-2020 IPONWEB Ltd. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) enable_language(ASM) diff --git a/src/host/CMakeLists.txt b/src/host/CMakeLists.txt index 1ce3e224..3ca158a5 100644 --- a/src/host/CMakeLists.txt +++ b/src/host/CMakeLists.txt @@ -1,7 +1,7 @@ # Building the toolchain for LuaJIT VM preprocessing. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) # FIXME: Both minilua and buildvm need to be build with the HOST_* # toolchain. diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt index 3ad5d15f..8af043f7 100644 --- a/test/CMakeLists.txt +++ b/test/CMakeLists.txt @@ -1,7 +1,7 @@ # Running various test suites against LuaJIT. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) include(MakeLuaPath) diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt index a0fb5440..a884070a 100644 --- a/test/LuaJIT-tests/CMakeLists.txt +++ b/test/LuaJIT-tests/CMakeLists.txt @@ -1,5 +1,5 @@ # See the rationale in the root CMakeLists.txt -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) add_subdirectory(src) diff --git a/test/LuaJIT-tests/src/CMakeLists.txt b/test/LuaJIT-tests/src/CMakeLists.txt index 2f90da86..704c7acf 100644 --- a/test/LuaJIT-tests/src/CMakeLists.txt +++ b/test/LuaJIT-tests/src/CMakeLists.txt @@ -1,5 +1,5 @@ # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) # Use `lib` prefix for loading via FFI and `require()`. AddTestLib(libctest libctest.c) diff --git a/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt b/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt index 98277f9a..7820d39b 100644 --- a/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt +++ b/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt @@ -2,7 +2,7 @@ # in scope of https://github.com/tarantool/tarantool/issues/5845. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) # XXX: There are two ways to set up the proper environment # described in the suite's README: diff --git a/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt b/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt index b496cbab..d34151e1 100644 --- a/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt +++ b/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt @@ -2,7 +2,7 @@ # in scope of https://github.com/tarantool/tarantool/issues/5845. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) # Build additional C libraries for tests. AddTestLib(lib1 lib1.c) diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt index f748a8fd..2b4bb0ab 100644 --- a/test/lua-Harness-tests/CMakeLists.txt +++ b/test/lua-Harness-tests/CMakeLists.txt @@ -2,7 +2,7 @@ # in scope of https://github.com/tarantool/tarantool/issues/5844. # See the rationale in the root CMakeLists.txt -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) find_program(PROVE prove) if(NOT PROVE) diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt index e6d12984..c505f196 100644 --- a/test/tarantool-tests/CMakeLists.txt +++ b/test/tarantool-tests/CMakeLists.txt @@ -2,7 +2,7 @@ # scope of https://github.com/tarantool/tarantool/issues/4478. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) find_program(PROVE prove) if(NOT PROVE) diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt index 695c079a..09fe0230 100644 --- a/tools/CMakeLists.txt +++ b/tools/CMakeLists.txt @@ -4,7 +4,7 @@ # Copyright (C) 2015-2020 IPONWEB Ltd. # See the rationale in the root CMakeLists.txt. -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) set(LUAJIT_TOOLS_DEPS) -- 2.34.1