From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0D95C6EC58; Thu, 5 Aug 2021 01:26:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D95C6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628115989; bh=tiRcjb7Wjz1ag39HTeznwc/wArDP2n963GSKMkBAFho=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YYHMvk2+jRIvWAVXCDHKFd8a81KZDjTM5V6qFd50SNb+qQYmARhlTVFTsoCWcatv1 r85cDaZD4xdqFRtTTjUG0vaCk5o8elMaG2rGeYFPqHQ9V0YrarY5yd/OnlSZuAQ020 iDSzUvjwr8pVS9scB6SqpxcBAxLBCchfcsZ7RmdQ= Received: from smtpng2.i.mail.ru (smtpng2.i.mail.ru [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 500146EC58 for ; Thu, 5 Aug 2021 01:26:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 500146EC58 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1mBPLG-0006rK-Nj; Thu, 05 Aug 2021 01:26:27 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <58a114d408cdfb9f82f2f11005a93981d392de38.1627504973.git.imeevma@gmail.com> Message-ID: Date: Thu, 5 Aug 2021 00:26:25 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <58a114d408cdfb9f82f2f11005a93981d392de38.1627504973.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B20CA14D9DFB46B94A182A05F53808504080212E1FF34F7D6C84706828C9AB22FE058968B85AD8D9B76B85DD35392945B6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789805A6418246A1AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637EDC9855826FBDF5A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8594E020E5160ACA8AF6F90A5D0A5634F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505881C34328C8F5CEECE9A0690FE374C6D X-C1DE0DAB: 0D63561A33F958A52850D3B4B64AC7AC3FD3D439EB3654DF1C16DE219A45E5F8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349FD10E01B3CDC9E215BA8E6DDAAEB46B04B0B046DD8932C9C920685ED936AB29348DC8182CEE97301D7E09C32AA3244C9C9A419874F0EBBF80390E3096D81DD21E098CBE561D6343729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3XWuIQgrSMjbA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DC87E2714E7D6449E6A2AF84133B90A383841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 4/7] sql: remove unnecessary calls of OP_ApplyType X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/sql/wherecode.c b/src/box/sql/wherecode.c > index 96bcab110..92d374200 100644 > --- a/src/box/sql/wherecode.c > +++ b/src/box/sql/wherecode.c <...> > -/** > - * Expression @rhs, which is the RHS of a comparison operation, is > - * either a vector of n elements or, if n==1, a scalar expression. > - * Before the comparison operation, types @types are to be applied > - * to the @rhs values. This function modifies entries within the > - * field sequence to SCALAR if either: > - * > - * * the comparison will be performed with no type, or > - * * the type change in @types is guaranteed not to change the value. > - */ > -static void > -expr_cmp_update_rhs_type(struct Expr *rhs, int n, enum field_type *types) > -{ > - for (int i = 0; i < n; i++) { > - Expr *p = sqlVectorFieldSubexpr(rhs, i); > - enum field_type expr_type = sql_expr_type(p); > - if (sql_type_result(expr_type, types[i]) == FIELD_TYPE_SCALAR || > - sql_expr_needs_no_type_change(p, types[i])) { sql_expr_needs_no_type_change is now unused.