From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B62B54696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Apr 2020 10:36:00 +0300 (MSK)
References: <cover.1584358124.git.lvasiliev@tarantool.org>
 <20200401113307.GR22874@tarantool.org>
From: lvasiliev <lvasiliev@tarantool.org>
Message-ID: <a176e6de-24df-1eab-13b3-6a7e499e62fc@tarantool.org>
Date: Thu, 2 Apr 2020 10:35:58 +0300
MIME-Version: 1.0
In-Reply-To: <20200401113307.GR22874@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Fix some options of rocks
 module
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imun@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hi, thanks for the review.

On 01.04.2020 14:33, Igor Munkin wrote:
> Leonid,
> 
> Thanks for the series! Considering your post-review fixups and omitting
> other comments I have regarding the tarantoolctl code, it LGTM.
> 
> Please add a ChangeLog entry for your patchset.
Done 
(https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all)

@Changelog
Fixed the tarantoolctl rocks search flag --all

and

@Changelog
Fixed the tarantoolctl rocks remove flag --force
> 
> Sasha, please proceed with the series.
> 
> On 16.03.20, Leonid Vasiliev wrote:
>> https://github.com/tarantool/tarantool/issues/3632
>> https://github.com/tarantool/tarantool/issues/4529
>> https://github.com/tarantool/tarantool/tree/lvasiliev/gh-4529-fix-show-all
>>
>> Some new options (--all and --force) have been added to the white-list for forwarding to the tarantoolctl rocks module.
>>
>> Leonid (2):
>>    luarocks: Add a kludge for option all of luarocks search
>>    luarocks: Add a kludge for option force of luarocks remove
>>
>>   extra/dist/tarantoolctl.in | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> -- 
>> 2.17.1
>>
>