From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EF05FA58481; Fri, 22 Mar 2024 18:23:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EF05FA58481 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711121021; bh=AsG1sj0ENF+4JtX18fKQzYV46ebPs5QJLSOyfygv90o=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hSGmyK9Q9vOskpCNzj8v6bB567ORaxrLw5G6+K8zK9zWnSYz6ZeMYklzi3PBt8XV+ BJw/HZW67g3tmnZVG8i2zIhUlLPHv7yJmRObsTUpCbM1n4EmsaNxg5ttjL0UO825AL z2ncsptpNwj84qkj2FvHKCmr/Bi3gd6nW4/3MU2o= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C2DB7A584BE for ; Fri, 22 Mar 2024 18:23:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C2DB7A584BE Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1rngk6-0000000FvEn-3b1T; Fri, 22 Mar 2024 18:23:39 +0300 Message-ID: Date: Fri, 22 Mar 2024 18:23:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin , Sergey Bronnikov References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92CB91DAA594FB6BFF2A3A4ED2927076685388FBF15026591182A05F538085040D1646917266332AC411046492FDDF806EFA4B2D6DF131DC72E5579CB05CA6558BDDFA93EA4B3182B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7484B509D84968742EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370F98874192B1BA168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8775FA58BC430662C9E32FBBF1F31A45E885AEA96AB4B44F5CC7F00164DA146DAFE8445B8C89999728AA50765F7900637BA939FD1B3BAB99B389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8989FD0BDF65E50FBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AF6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3B74263D4D5690889BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFCF36E64A7E3F8E581DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3F6A27782D052760535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A57D92A5804D6635495002B1117B3ED6965312AA34E9D46E16484B8D70797403F6823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34CAFBC0A7A4BEEE014236B289A47783AD14F90FB0637F839820EF7987962CB8356103C257B1211A5A1D7E09C32AA3244C40FC29275642931C7215182CA7F28860846780D441B240A2EA455F16B58544A21C197AAF4D2E4732A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxpsVEd/A9aPDFeh1889dbg== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B592BAAA3F6766EE63F411046492FDDF806EFA4B2D6DF131DC7B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] cmake: fix warnings about minimum required version X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, thanks for your comments! On 3/21/24 13:13, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > On Thu, Mar 21, 2024 at 11:33:29AM +0300, Sergey Bronnikov wrote: >> From: Sergey Bronnikov >> >> CMake produces annoying warnings: >> >> CMake Deprecation Warning at src/CMakeLists.txt:7 (cmake_minimum_required): >> Compatibility with CMake < 3.5 will be removed from a future version of >> CMake. >> >> We cannot bump a minimum required CMake version without >> bumping it in a Tarantool build system. However, we can set > Typo: s/in a/in the/ Fixed. >> a max supported CMake version and suppress a warning. > Please specify in the commit message and in comments in cmake files > that maximum supported version means "maximum version this CMake file > is known to work properly" and will not result in any build errors > rightaway for higher versions. Added. >> CMake 3.27.7 is a version used by me for a long time for >> building LuaJIT. This version is tested and seen no policy warnings > Typo: s/is tested/has been tested/ > Typo: s/there have been/ Fixed. >> with a that version. > Typo: s/a that/that/ Fixed. >> --- >> Branch: https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings >> Doc: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html >> >> NOTE: another solution is using CMAKE_WARN_DEPRECATED, >> but I don't like it. Let's discuss. >> >> 1. https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html >> >> CMakeLists.txt | 2 +- >> etc/CMakeLists.txt | 2 +- >> src/CMakeLists.txt | 2 +- >> src/host/CMakeLists.txt | 2 +- >> test/CMakeLists.txt | 2 +- >> test/LuaJIT-tests/CMakeLists.txt | 2 +- >> test/LuaJIT-tests/src/CMakeLists.txt | 2 +- >> test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt | 2 +- >> test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 2 +- >> test/lua-Harness-tests/CMakeLists.txt | 2 +- >> test/tarantool-tests/CMakeLists.txt | 2 +- >> tools/CMakeLists.txt | 2 +- >> 12 files changed, 12 insertions(+), 12 deletions(-) >> >> diff --git a/CMakeLists.txt b/CMakeLists.txt >> index 7f5e2afb..9edff6f3 100644 >> --- a/CMakeLists.txt >> +++ b/CMakeLists.txt >> @@ -8,7 +8,7 @@ >> >