From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EC8472542F for ; Thu, 17 May 2018 11:05:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V9VfKwpzQ3r7 for ; Thu, 17 May 2018 11:05:17 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A8A0225424 for ; Thu, 17 May 2018 11:05:17 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] sql: remove temporary box_iterator_key_def References: <98d8572affd09ca99e92f29e90165ca29f664847.1526564450.git.kyukhin@tarantool.org> From: Vladislav Shpilevoy Message-ID: Date: Thu, 17 May 2018 18:05:15 +0300 MIME-Version: 1.0 In-Reply-To: <98d8572affd09ca99e92f29e90165ca29f664847.1526564450.git.kyukhin@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Yukhin Hello. Thanks for the patch! On 17/05/2018 16:41, Kirill Yukhin wrote: > It is possible to extract key_def from iterator directly > in SQL FE. So, no need in any temporary API hacks anymore. > The patch removes this API function and replaces its calls > w/ direct field access in SQL FE. > > Closes #2425 > --- 1. Please, post branch and issue links here. 2. I can not find any branch with 2425 in name. The patch LGTM.