From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 986B94003E9 for ; Sat, 19 Oct 2019 01:03:05 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: Date: Sat, 19 Oct 2019 00:08:13 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [tarantool-patches] [PATCH v1 0/5] Replace control pragmas by SET List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@freelists.org, imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the patchset! Mostly the design is ok. Consider a question below. What about having a more general settings space? For all session settings. Named like '_vsession_settings'. Or '_vsession_storage'. It will be exactly like in your patchset, but all SQL settings will have 'sql_' prefix. And then we could reuse that space for other settings, even from not SQL, like Kostja planned. I am just afraid, that number of system spaces grows without a control. With current pace we have only 16 free IDs left for system spaces. Next are user space. See, now we've used 380. The last is 511. Interval is 8. 131 / 8 = 16. And we can't put them tighter. We need 8-width gaps to be able to insert new spaces between existing ones when a certain recovery order will be needed. 16 is not really many, taking into account a pile of information schema views going to be added. On 17/10/2019 16:40, imeevma@tarantool.org wrote: > This patch0set created a new SQL command: SET. This command is > used to change SQL settings, including debugging settings. > > The main goal of this fix pack version is to choose a design to > solve the problem. > > https://github.com/tarantool/tarantool/issues/4511 > https://github.com/tarantool/tarantool/tree/imeevma/gh-4511-pragma-replaced-by-set >