From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8659F278F9
	for <tarantool-patches@freelists.org>; Fri, 27 Jul 2018 06:02:06 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id tYuV9qUV2Tow for <tarantool-patches@freelists.org>;
	Fri, 27 Jul 2018 06:02:06 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CA50426545
	for <tarantool-patches@freelists.org>; Fri, 27 Jul 2018 06:02:05 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: prevent executing
 crossengine sql
References: <aa9d1ac8d749bd0dc5e1f189d8480bdd907d1701.1532430181.git.kshcherbatov@tarantool.org>
 <cover.1532430181.git.kshcherbatov@tarantool.org>
 <a1bf1a61c86205718ca465c5fa189bbbcf273188.1532430181.git.kshcherbatov@tarantool.org>
 <281C2B94-5BA3-4868-B3A5-53234E2DCA4D@tarantool.org>
 <a685a228-1758-85c2-eaee-403ea8cd1eb8@tarantool.org>
 <12091997-2a63-951d-9477-86c3429d981d@tarantool.org>
 <c33a438c-973c-e263-7681-aa1453e4cb15@tarantool.org>
 <589c2e7f-7701-d075-8c91-6d5707e6a9a5@tarantool.org>
 <b2a4fbdb-8074-cc25-a1c4-cbc7bb5d42a3@tarantool.org>
 <d085d614-d77f-69c6-32da-41f12b08a98d@tarantool.org>
 <d757e078-0806-c3e8-f6a3-8d45cdf283b2@tarantool.org>
 <72ec02db-6c05-9652-8455-bcb99c35a8a6@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <a0d89298-b5d4-e60d-eb8a-fdb7aad8db1c@tarantool.org>
Date: Fri, 27 Jul 2018 13:02:03 +0300
MIME-Version: 1.0
In-Reply-To: <72ec02db-6c05-9652-8455-bcb99c35a8a6@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>



On 27.07.2018 11:55, Vladislav Shpilevoy wrote:
> Hi! I do not see your answer. You've just sent empty email with my cite.
> 
> On 27/07/2018 10:13, Kirill Shcherbatov wrote:
>>> Thanks for the fixes! I have pushed my own on the branch.
>>> Please, squash.
>>>
>>> Sorry, I was wrong about txn != NULL omitting. If we omit it,
>>> then for ephemeral spaces we do not start ro stmt, but commit
>>> it. It is not correct.
>>>
>>> Your code works only because commit_ro() is no-op when we
>>> have an active transaction. But it can change in futureThank you for review. I've squashed this changes.
Oh, sorry. It is kind of misunderstanding. Maybe I've press Enter on selected text before send via Ctrl+Enter.Thank you for review. I've squashed your changes.