From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 968D264672; Wed, 13 Jan 2021 10:59:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 968D264672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610524740; bh=OhPlavPeDfmtBwL5YNfkDbe+jOyJvikXqw71lqQBou4=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rfH1u1ft/oa4dUpQunJ3UJX0dDEwZH67fn84HikZ3zPpcd8hIEaJP9Uwx6YaQ7et8 bwZALUVTBt+ZxtCljHml812w5EBp3wPyhFBbv19M6N6lEqaeefvlVJFf8lTGbPxbvh ijO6r832sDullNx5P5u/4F/LATlZRqnG+5bA3zrw= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0D31F64672 for ; Wed, 13 Jan 2021 10:58:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D31F64672 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1kzb3S-0004mA-5a; Wed, 13 Jan 2021 10:58:58 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, lvasiliev@tarantool.org References: <08266e7e73c778c80dd9954b4e45fe1d5cfa9b21.1608647958.git.estetus@gmail.com> <63ceba2d-9aa3-84db-9d56-7d15a2053167@tarantool.org> <24c86655-d972-ff0c-feef-a42f2bb16dfb@tarantool.org> Message-ID: Date: Wed, 13 Jan 2021 10:58:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <24c86655-d972-ff0c-feef-a42f2bb16dfb@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CDC332107C56D78A30EABAEB9DEE13ADFC00894C459B0CD1B9DBBF3D129955DDB49BC6F9708262DF4321B3189970C009A529FF1465CC0F6BAA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77603ADE015AF816DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF05F7050DCA185A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC081036C1CE0AB3143A5C9D72D51B8CD3E33180E64A7733D6389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C08B0023DF17FBB7E08941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B66EA1BA7CA28B4A74CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC02324478173250CF75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E7353218473BE5707D41C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F5D41B9178041F3E72623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5B4357462692757D0DE2305AAD76A90E9FA687722D79ACF35D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B3611847B8BC2D0B0F26066C4AA26ABD43BF390FEFE10FE8504080658199AA54DA1C3523307259551D7E09C32AA3244CD3744CA84CC77639C456DA577082BE52E3D93501275E802FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj4exXbGs3yZpioFUZ76/seg== X-Mailru-Sender: 689FA8AB762F73937240DDB2502DDB701EF0C4DF04A7EDC489DC32F16D43771CDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/3] luacheck: fix warnings in test/box X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 12.01.2021 18:26, Sergey Bronnikov via Tarantool-patches wrote: > Thanks for review! > > On 11.01.2021 20:52, Vladislav Shpilevoy wrote: >> Hi! Thanks for the patch! >> >> See 2 comments below. >> >>> diff --git a/.luacheckrc b/.luacheckrc >>> index 4b829f3dc..17cff8671 100644 >>> --- a/.luacheckrc >>> +++ b/.luacheckrc >>> @@ -102,3 +108,53 @@ files["src/box/lua/console.lua"] = { >>>           "212", >>>       } >>>   } >>> +files["test/box/box.lua"] = { >>> +    globals = { >>> +        "cfg_filter", >>> +        "sorted", >>> +        "iproto_request", >>> +    } >>> +} >>> +files["test/box/lua/push.lua"] = { >>> +    globals = {"push_collection"} >>> +} >>> +files["test/box/lua/index_random_test.lua"] = { >>> +    globals = {"index_random_test"} >>> +} >>> +files["test/box/lua/utils.lua"] = { >>> +    globals = { >>> +        "arithmetic", >>> +        "check_space", >>> +        "create_iterator", >>> +        "iterate", >>> +        "setmap", >>> +        "sort", >>> +        "space_field_types", >>> +        "space_bsize", >>> +        "table_generate", >>> +        "table_shuffle", >>> +        "tuple_to_string", >> 1. All these functions are returned by the module. It means, >> they are supposed to be used like this: >> >>     utils = require('utils.lua') >>     utils.setmap() >>     utils.space_bsize() >>     -- etc >> >> This in turn means you need to make them all 'local' in utils.lua. >> I did it, and the tests pass. Also some of these functions are >> probably unused, but I didn't check. >> >> The same for identifier.lua below. > > - removed some functions from interfaces and their implementations reverted change because removed functions are used by other suites (for example vinyl)