From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B850E6DB22; Thu, 14 Nov 2024 18:55:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B850E6DB22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1731599715; bh=GnG/Z9EY91+o9lKrKML8GJerLAo90DTO07HvagJnVcQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=hb2sY6OwnQ21rWTFe0stKYq5AE4xEC4lJ6Btq5dHC5jnTFRnsHqErWlSbK8Ui1ZXY M7pG3wXgSgjml8d5FUnLM3XRRFG/7vZ631ponWSNDacCy+rBJIyknEZExKII1s+5zo a44ud9n4oqHTYhG4320ZbIqeLDrENnw0hJTkgWNs= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4ACD26DB22 for ; Thu, 14 Nov 2024 18:55:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4ACD26DB22 Received: by exim-smtp-6b485ccbfc-xwscd with esmtpa (envelope-from ) id 1tBcBc-000000001TE-1nH2; Thu, 14 Nov 2024 18:55:12 +0300 Date: Thu, 14 Nov 2024 18:54:25 +0300 To: mandesero@gmail.com, tarantool-patches@dev.tarantool.org Message-ID: References: <41109126-36d0-4e5f-8d2c-25d3fc5ed6b7@tarantool.org> <20241111110342.7519-1-mandesero@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD916BE56C417C48A21383D878BB30A34FE77E44BC803FE680500894C459B0CD1B9C9FED1140CB61BBE9487ABAC94A94B548525DF351CDD1D979D1358487E1B90C4EB35CB8B4FE073DF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE741DC22BF90A736D8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F08BD7C3AB07DC7F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F1CE3C75AC1A305A6307C44A5D6C6F60983B992E56ED10B6CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9EB32FE0C26A3A4C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5D3D30523A91452A45002B1117B3ED69681199920B8851481E99897350C7C491E823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFF87C36E32677FBAC34D82F2A293BF9209380A84244645117076102054D021E0880C7DAD1783D929BD91475F11186E2007A72DC8268D7DC18F534B152604459B39E7714CB41CFC979111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUjlJs7fo7WnUPJxIdiCCZw== X-DA7885C5: 6676E47E30FE2D84F255D290C0D534F9776CE0BD7C13D18482D76B9D0E7E899A1406D04EAB7CC3DC5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA21994F76022BE9787C2791E02FA352287F25D415D879E510620E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 luajit 1/2] cmake: run tests with Valgrind X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 14.11.24, Sergey Kaplun via Tarantool-patches wrote: > Hi, Maksim! > Thanks for the patch! > Please consider my comments below. > > On 11.11.24, mandesero@gmail.com wrote: > > - test/tarantool-tests/lj-512-profiler-hook-finalizers.test.lua > > - test/tarantool-tests/lj-726-profile-flush-close.test.lua > > - test/tarantool-tests/misclib-sysprof-lapi.test.lua I also get the following error locally: | test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua (SIGPROF) So, it looks like all sysprof's tests should be disabled. > > > > Timed out due to running under Valgrind: > > - test/tarantool-tests/gh-7745-oom-on-trace.test.lua > > - test/tarantool-tests/lj-1034-tabov-error-frame.test.lua > > Also, I've found that tests from LuaJIT-tests suite reports tons of the assertions, but still the suite passes. This should be fixed: I suppose that we need to set `--error-exitcode` option as well. The option `--exit-on-first-error` may be also considered. | ctest --verbose -L LuaJIT-tests | ... | 2: ==20374== Command: /home/burii/reviews/luajit/valgrind-ci/src/luajit -e dofile[[/home/burii/reviews/luajit/valgrind-ci/test/luajit-test-init.lua]] /home/burii/reviews/luajit/valgrind-ci/test/LuaJIT-tests/test.lua +slow +ffi +bit +jit | 2: ==20374== | 2: ==20374== Invalid read of size 4 | 2: ==20374== at 0x137059: lj_getu32 (lj_def.h:244) Same for PUC-Rio-Lua-5.1-tests, lua-Harness-test. Also, I see these warnings for tarantool-tests suite as well, see | ctest --verbose -R test/tarantool-tests/fix-jit-dump-ir-conv.test.lua for example: | 82: ==25641== Conditional jump or move depends on uninitialised value(s) | 82: ==25641== at 0x1BCD8F: lj_BC_ADDVN (/home/burii/reviews/luajit/valgrind-ci/src/lj_vm.S:252) | 82: ==25641== by 0x1445F3: lj_vmevent_call (lj_vmevent.c:46) | 82: ==25641== by 0x186EB5: trace_stop (lj_trace.c:555) | 82: ==25641== by 0x184422: trace_state (lj_trace.c:726) | 82: ==25641== by 0x1BE97D: lj_vm_cpcall (/home/burii/reviews/luajit/valgrind-ci/src/lj_vm.S:1266) | 82: ==25641== by 0x183CA1: lj_trace_ins (lj_trace.c:757) | 82: ==25641== by 0x1263C4: lj_dispatch_ins (lj_dispatch.c:430) | 82: ==25641== by 0x1C0D69: lj_vm_inshook (/home/burii/reviews/luajit/valgrind-ci/src/lj_vm.S:2649) | 82: ==25641== by 0x11FCCA: lua_pcall (lj_api.c:1173) | 82: ==25641== by 0x112A84: docall (luajit.c:133) | 82: ==25641== by 0x112620: handle_script (luajit.c:304) | 82: ==25641== by 0x111B9C: pmain (luajit.c:604) Also, I confused with the Command content, It looks like the valgrind with its options is missed. Also, it would be nice to run all tarantool-c-tests under valgrind. Also, what do you think about enabling option `--track-fds` for the CI (maybe in the separate patch set). -- Best regards, Sergey Kaplun