From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BF77AD0407E; Thu, 17 Oct 2024 10:16:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF77AD0407E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1729149419; bh=lKvIme3yofQGDS8MMqBSt7SAwtZ4aFhQP71tqzhKrfI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WcL40h8diM+quuFdkB+eYnAmhTX9F8ZnpbkuvLxzGF7EHJWfeSGbmyYizdvnCICJK AFYAWslQoRu/9pL6sJdHGWFwYkM+TciQlufbuPuFwDV7yv5z6vUpMujbvFBWn8K1GL kKUP/VWaqBV/7CZ54EXNsHCCj2A5bPqg5T0Qm9ts= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 17F9F5C3F0D for ; Thu, 17 Oct 2024 10:16:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 17F9F5C3F0D Received: by exim-smtp-6c4974b5fc-v5fpp with esmtpa (envelope-from ) id 1t1Kkg-000000000ML-2tS9; Thu, 17 Oct 2024 10:16:57 +0300 Date: Thu, 17 Oct 2024 10:16:22 +0300 To: Sergey Bronnikov Message-ID: References: <20240925103656.14771-1-skaplun@tarantool.org> <2486af85-0af6-4073-952c-ce5ce5a86d5c@tarantool.org> <17fd3424-51f8-42ed-8c28-143c99876ce7@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17fd3424-51f8-42ed-8c28-143c99876ce7@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD923F1B5F87BDC70E67131810E6EC1A7C217CA179BF99858C0182A05F5380850403CD073FC906DD0F73DE06ABAFEAF6705210AE9AF0F684E58276A6CA8ADBDEA144634D9B51EFD7DC0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745229D52CF30560CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063707C4856229E8E7E48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D847C9E72989393BE45F34D3FB1589D0237E6643D2757FCF07CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC80CABCCA60F52D7EBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BAEB924C2B054B06E75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A58B0698E080476ED05002B1117B3ED6969FF239409933BC9C559C6C5561145D6F823CB91A9FED034534781492E4B8EEADEEA082C9A12FE455BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF81E8BC92F4B72D23B99FF086CC20A8F60234D59F9DC511173B266EA643026505E98901B1639BBD3F42A7D8B9DDB4327BF9A013F6254E797E695BC380762A71AFFA972C0F925873FC5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSRbVk4UM9X04qSlinVd6mQ== X-DA7885C5: 982062F28AE38C8CF255D290C0D534F96087C23E9C6D3E9596DCBD3569B871BB9BF94B5282C046885B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219B207341FEC35C9E91ACB643728423A348435A64D45830E96E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Limit CSE for IR_CARG to fix loop optimizations. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 11.10.24, Sergey Bronnikov wrote: > Hi, Sergey! > > On 08.10.2024 16:25, Sergey Kaplun wrote: > > > > >>> +ffi.cdef[[ > >>> + double sin(double, ...); > >>> + double cos(double, ...); > >> Why do you use sin/cos with wrong function prototypes if you can take > >> > >> a function with varargs. (printf for example)? > > I suppose this hack is well suited for our testing purposes: > > 1) We don't need to create custom vararg functions and the corresponding > > C libary. > > 2) Functions usage is obvious. Also, the vararg part will be silently > > ignored. > > > > Be aware that we need the result of the function's call. > > > Got it. I would add this as a comment. Feel free to ignore. I've added the following comment: =================================================================== diff --git a/test/tarantool-tests/lj-1244-missing-phi-carg.test.lua b/test/tarantool-tests/lj-1244-missing-phi-carg.test.lua index 865cdd26..d4981299 100644 --- a/test/tarantool-tests/lj-1244-missing-phi-carg.test.lua +++ b/test/tarantool-tests/lj-1244-missing-phi-carg.test.lua @@ -17,6 +17,9 @@ local NTESTS = 6 test:plan(NTESTS) +-- XXX: Hack with function's prototypes to avoid creation of +-- custom functions to be loaded via FFI (vararg part will be just +-- ignored). ffi.cdef[[ double sin(double, ...); double cos(double, ...); =================================================================== Branch is rebased on the current master and force-pushed. > > LGTM -- Best regards, Sergey Kaplun