From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D56E9CD5C3D; Sat, 12 Oct 2024 10:01:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D56E9CD5C3D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1728716474; bh=bC7uhKoW8f2svRus2Gz3C84PZB+FZ45bE6fl8kre9oU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vlGY7NxGdq1J+GYOL6U3iDJVcG9ZxJwb6pwW7HQ6etDHc3ByVfdiuxHdWOwdQnGLU ffA1f6f7FQBLeqE8dKVFIoH1OOyDXB4IHVpMkrFlmk6hiEu1580HZVyU6Yusm9a72k 6QCKHb5wv9kLO22nPepflItVXwa7Pt3varcES2ig= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C2E175CB6B9 for ; Sat, 12 Oct 2024 10:01:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C2E175CB6B9 Received: by exim-smtp-57f79c7799-cprh4 with esmtpa (envelope-from ) id 1szW7k-00000000RwR-3i36; Sat, 12 Oct 2024 10:01:13 +0300 Date: Sat, 12 Oct 2024 10:00:40 +0300 To: Maxim Kokryashkin Message-ID: References: <15a3b416520eac8f799a59fa51c6dcd9515ec90b.1727172936.git.skaplun@tarantool.org> <2mst2bpxwtdb72ivhgezbreecwzrvfa6rs77dz5q5rjtfvqiy2@ap3jrgnzhojw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2mst2bpxwtdb72ivhgezbreecwzrvfa6rs77dz5q5rjtfvqiy2@ap3jrgnzhojw> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B01871A0ED523BBF32CE30BE1D7BB39A1060E4D055FFF490182A05F538085040D19011A6978B36DB3DE06ABAFEAF6705C57DA29ED72E7BA7C5162851FC28663200A643622B2F607C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7965AF5021CACFC74C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE78C722B68A3D10D1CEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36090FB8D6739DE37A08B235BF43C7FF2595ED4A4F6732C29BA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5ADD918A60FD1F9495002B1117B3ED696978A4DC2C235857D7E0012C66AE17B00823CB91A9FED034534781492E4B8EEAD8D8BB953E4894305BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA0224AFAE622301D57B68E47EF2BD8CA6602F0EFAA6E6C151E6DFEC9AF84588CA4B23375CB3901BD96F871248C7F69EC2F3FBA545D2DC70E2ACCA97EB0356B9DC1CA04761F75301A5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojY+/NKRaruBVpGpOe0dH9KQ== X-DA7885C5: 316A83A49E2E9A96F255D290C0D534F9A8972E9094E4EB8BD6544A6F522D85C336E1CF87D6AC43F35B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B9BBFD5D45303B60830C665F52548577A952A7F461E6B30CAE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 5/7] test: shrink LUA_CPATH and {DY}LD_LIBRARY_PATH X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment and force-pushed the branch. On 11.10.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a single nit below. > > On Tue, Sep 24, 2024 at 01:29:50PM GMT, Sergey Kaplun wrote: > > This patch sets the unique value of each of these variables for each of > > the tests and only where they are needed. Also, it drops the comment > > about SIP [1] tricks since it is obsolete after > > 29897567ee5ed57e961c730432c056a3dbaa8f09 ("test: stop using > > utils.selfrun in tests"). > > > > [1]: https://support.apple.com/en-us/HT204899 > > > > Resolves tarantool/tarantool#9898 > > --- > > test/tarantool-tests/CMakeLists.txt | 85 ++++++++----------- > > test/tarantool-tests/ffi-ccall/CMakeLists.txt | 2 +- > > .../fix-bit-shift-generation/CMakeLists.txt | 3 +- > > .../gh-4427-ffi-sandwich/CMakeLists.txt | 3 +- > > .../CMakeLists.txt | 3 +- > > .../gh-6189-cur_L/CMakeLists.txt | 3 +- > > .../lj-1004-oom-error-frame/CMakeLists.txt | 3 +- > > .../CMakeLists.txt | 3 +- > > .../lj-1166-error-stitch/CMakeLists.txt | 6 +- > > .../lj-416-xor-before-jcc/CMakeLists.txt | 3 +- > > .../CMakeLists.txt | 3 +- > > .../lj-549-bytecode-loader/CMakeLists.txt | 3 +- > > .../CMakeLists.txt | 3 +- > > .../lj-601-fix-gc-finderrfunc/CMakeLists.txt | 3 +- > > .../lj-727-lightuserdata-itern/CMakeLists.txt | 3 +- > > .../CMakeLists.txt | 3 +- > > .../lj-flush-on-trace/CMakeLists.txt | 3 +- > > .../both/CMakeLists.txt | 4 +- > > .../gnuhash/CMakeLists.txt | 4 +- > > .../hash/CMakeLists.txt | 4 +- > > .../stripped/CMakeLists.txt | 4 +- > > 21 files changed, 82 insertions(+), 69 deletions(-) > > > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > > index 5e3493b6..d0964aed 100644 > > --- a/test/tarantool-tests/CMakeLists.txt > > +++ b/test/tarantool-tests/CMakeLists.txt > > @@ -5,17 +5,16 @@ add_custom_target(tarantool-tests-libs > > DEPENDS libluajit > > ) > > > > -macro(BuildTestCLib lib sources) > > - AddTestLib(${lib} ${sources}) > > +macro(BuildTestCLib lib source for_tests) > > This whole macro signature now reads something like `lib source > for_tests` which looks kind of misleading, especially in the code below. > > IMO, it would be better to call the last variable like `dependent_tests` > for better readability. Feel free to ignore, though. Renamed as you suggested: =================================================================== diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt index 297d5801..0f9bca69 100644 --- a/test/tarantool-tests/CMakeLists.txt +++ b/test/tarantool-tests/CMakeLists.txt @@ -5,12 +5,12 @@ add_custom_target(tarantool-tests-libs DEPENDS libluajit ) -macro(BuildTestCLib lib source for_tests) +macro(BuildTestCLib lib source dependent_tests) AddTestLib(${lib} ${source}) add_dependencies(tarantool-tests-libs ${lib}) # Remember libraries for each test to be proceeded with after # test targets are created. - foreach(testname ${for_tests}) + foreach(testname ${dependent_tests}) set(LIBS_${testname} "${CMAKE_CURRENT_BINARY_DIR};${LIBS_${testname}}" PARENT_SCOPE ) =================================================================== > > -- > > 2.46.0 > > -- Best regards, Sergey Kaplun