From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 691DDDB54A0; Tue, 8 Oct 2024 16:26:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 691DDDB54A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1728393977; bh=ZEQEeuWxsG4Rvn6phKK7kEIXyou/xzxc1bkdI2yL5W4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Q2csRT69uLS/uYsDKod+wNvFW+ekvknJA1oxG7jLOp1DLBmqbE9nZI/7Aph+mai6D /DCWYEoX+WYzmZuqkE9RZ7aHtSQIpJOJ/BbFTsXJGHO9rw5ZD18M2C85ANX3E82iEq 2nsaVLf/HxxNSUC+Yumk/XjYLpvMagFTkRwbxj8M= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [95.163.41.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F31C4DB5481 for ; Tue, 8 Oct 2024 16:26:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F31C4DB5481 Received: by exim-smtp-57dbb65494-c8gcl with esmtpa (envelope-from ) id 1syAEB-000000000SF-3lTw; Tue, 08 Oct 2024 16:26:16 +0300 Date: Tue, 8 Oct 2024 16:25:45 +0300 To: Sergey Bronnikov Message-ID: References: <20240925103656.14771-1-skaplun@tarantool.org> <2486af85-0af6-4073-952c-ce5ce5a86d5c@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2486af85-0af6-4073-952c-ce5ce5a86d5c@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9B01871A0ED523BBF93215B4F211077CAAD35C5E5AA693CD1182A05F538085040745149701A3C9F5F3DE06ABAFEAF6705F5CFAE1188966A490B7A7E73AF286E2750BEE2EB090F92B7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72AC9FB60380F23AEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CDA089757FB31C668638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F7F07A3A2D48D8CAE95E150CB2A405C656147941A2F8029ECC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB662CFBDBA8F60F475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5AA7DA5B2E8E730665002B1117B3ED696DD3FA285859A4D8430E4A65F242F5898823CB91A9FED034534781492E4B8EEAD14747542773C033FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349FF8F8245A2FAA7B3CCC4295F08401A0630072A1BD48501D6AD9083A3EB46545A06C3D134DBD78EC1D7E09C32AA3244C9D1953207E96FBDF77DD89D51EBB774289B9F4439D958726EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/pBY5inp/EbV3u3KJU3d5w== X-DA7885C5: EADDF22FBCF00B83F255D290C0D534F9F164D8C7B11DE880908FC72E8AAEF7A1543A4A69FA1489975B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B2958CC1051271E763211EC245E7252CD64BB37CC3C0B73F3E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Limit CSE for IR_CARG to fix loop optimizations. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 08.10.24, Sergey Bronnikov wrote: > Hi, Sergey! > > LGTM with a minor question below. > > > +ffi.cdef[[ > > + double sin(double, ...); > > + double cos(double, ...); > > Why do you use sin/cos with wrong function prototypes if you can take > > a function with varargs. (printf for example)? I suppose this hack is well suited for our testing purposes: 1) We don't need to create custom vararg functions and the corresponding C libary. 2) Functions usage is obvious. Also, the vararg part will be silently ignored. Be aware that we need the result of the function's call. -- Best regards, Sergey Kaplun