From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 17CBFE88CED; Tue, 15 Oct 2024 10:40:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 17CBFE88CED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1728978041; bh=dUGnoJWBwtHp5gd+N2LYf7lxT5fqf8Shw+/XSibSoy8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=N/CPs5rau1qYGxl++Y0tIeVdIGFJqXA8V5HcKPmIUJpf3tbVJMM53zbJovEn2sNTE T40PL7SzNQ/lmFQWvGPXck6lUE2r7bjaU6bAgbYAkiRiRszGCrbOqWqhBTZl+Quak9 5lYKJl1+TwRXHYOvUdHvLHGhhVhDByQVER5psuUA= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [95.163.41.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7E3BEE8A17C for ; Tue, 15 Oct 2024 10:40:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E3BEE8A17C Received: by exim-smtp-57f79c7799-q7tc8 with esmtpa (envelope-from ) id 1t0cAY-00000000K5O-2OZq; Tue, 15 Oct 2024 10:40:38 +0300 Date: Tue, 15 Oct 2024 10:40:06 +0300 To: Maxim Kokryashkin Message-ID: References: <20240928103359.16057-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93347B6B2CAA5CFEE93F05716CFEBB3C6AA3014356CF10A65182A05F5380850406C8D5F81FB0CECCA3DE06ABAFEAF6705B91972B2EBF1B482B6A4D584AF8EE0FF5A4E072B40C18CE0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CA8E915ACC910FBDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374ECA27954A00B6C3EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C903F232C43C27BECEF73380D7F53F0BE9EE56CFC8DA5DEAA87A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BCE5475246E174218B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5FF18233D2FD9EC275002B1117B3ED6964B7AFE99C5B0A02447A99E6294EE8661823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AE88D5ADEBE7C983419580D03263044841F006DA1104DEEB3E012B1755DB88734126D7AF82AC9A581D7E09C32AA3244C2716C718F34CD92677DD89D51EBB774225C5975D5C9CDB3CEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojLPWNB68Sl1Kx+/X0BXQTCg== X-DA7885C5: 84641B9388740DFAF255D290C0D534F9C5B20BDD56FC392B774513493FBD236C9B8333A0A85514235B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F739381B31377CF4CA219DF89A66013F8ECE118F0DC11ADB29BABC87C0BCF5FE69123E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix misclib-getmetrics-lapi.test.lua X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! I fixed your comment, rebased branch to the current master, and force-pushed it. On 11.10.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a single nit regarding the commit message: > > On Sat, Sep 28, 2024 at 01:33:59PM GMT, Sergey Kaplun wrote: > > When run under Tarantool, the test may fail if Tarantool already has > > performed some finalize steps. This patch fixes it by making the test > > more general. > > --- > > IMO, it would be more readable to paraphrase like: > | When executed in Tarantool, the test might fail if Tarantool has > | already completed certain finalization steps. This patch > | addresses the issue by making the test more adaptable. > > -- Best regards, Sergey Kaplun