From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 60389EB64BC; Tue, 24 Sep 2024 14:45:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 60389EB64BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727178333; bh=TWhNZNSUsZcZ13FK8vTXaA4eH2H9dq+DQgzn5hRg9Xg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F3sw6jc7+1HdaHD1TqpElTDb+eQdP0IR91S6UjhbzRrO3ObF6/oRwIx8NNNKZ1z+a ktgYOz6N7srvFftQ3U5wfHouGgJ6QAbA3aFQZFc3L8SjttHHZqdepCCknuwk8HeIy5 9dDzfJidKCnS2Av6M3+mlxhCzoI+5ZNktExaubKs= Received: from smtp3.i.mail.ru (smtp3.i.mail.ru [95.163.41.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A9843EB64B8 for ; Tue, 24 Sep 2024 14:45:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A9843EB64B8 Received: by smtp3.i.mail.ru with esmtpa (envelope-from ) id 1st3z1-0000000897X-065A; Tue, 24 Sep 2024 14:45:31 +0300 Date: Tue, 24 Sep 2024 14:45:16 +0300 To: Sergey Bronnikov Message-ID: References: <746090ddd45350e52ecd3847758c0fd51cba23df.1727172936.git.skaplun@tarantool.org> <89ff148e-27d8-485d-a343-e1daff22d3ec@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <89ff148e-27d8-485d-a343-e1daff22d3ec@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD968D81A599CAF0ABB73F766E43C204C321F04E7B7F71F52B2182A05F5380850404026847D0BB77128C7A4B249DE6549FD1F31CC9C5C5ABD98913696E92C121A8514E64ECD1FAFC5AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78524CA6C6209E9ADEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375C4806A08D329A618638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85FF107C81F01994B7D423FAC1F7E661DC6ACC3B52D53C9A3CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8C2B5EEE3591E0D35F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B9149C560DC76099D75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5189C06462F44247D5002B1117B3ED696B848A85CD9226A88B48B7A7F94616420823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6497637054BC9084C62BB17E77108336948CB4C12F08D17E9F8F7C61405ADBEF45F8ED8E1771A93DA4322FFB9F042FEF58C0C514880E6BD35F53F98799AA5BAA5603D83774C2D88E5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojamSMdo1tbG83EyLJPBuu7g== X-DA7885C5: 885652C726FFFE47F255D290C0D534F90774646AC11EDB81FF3046981239F0099B216B51C32CBFAB5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B1FF591AB7EEC3460D9081B6C98E6B7FF3FDC661EF9915BEEE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 6/7] test: skip flaky tests with enabled table bump X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 24.09.24, Sergey Bronnikov wrote: > Hi, Sergey, > > test statuses from TAP report produced by tests is not propagated to CTest. > > I propose to disable these tests in CTest: > > > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -166,3 +167,14 @@ if(LUAJIT_USE_ASAN AND CMAKE_C_COMPILER_ID STREQUAL > "GNU") >      LD_PRELOAD ${LIB_ASAN} >    ) >  endif() > + > +set_tests_properties( > +  test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua > + test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua > + test/tarantool-tests/profilers/gh-5994-memprof-human-readable.test.lua > + > test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua > + > test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua > +  test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua > +  test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > +  PROPERTIES DISABLED TRUE > +) > > > CTest will always report that these tests are disabled and we will never > forget to enable them back: > > > 100% tests passed, 0 tests failed out of 158 > > Label Time Summary: > tarantool-tests    =  14.66 sec*proc (165 tests) > > Total Test time (real) =  14.73 sec > > The following tests did not run: >         222 - > test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua (Disabled) >         223 - > test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua > (Disabled) >         224 - > test/tarantool-tests/profilers/gh-5994-memprof-human-readable.test.lua > (Disabled) >         225 - > test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua > (Disabled) >         226 - > test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua > (Disabled) >         227 - > test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua (Disabled) >         228 - > test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua (Disabled) > > > What do you think? > Side note: this is new in 3.9, so we need to update CMake first. I'm not sure about this one. We also have all skipconditions inside the test itself, which makes it "self-sufficient" -- so if we look at the test, we know all builds when it is disabled. Adding another location may be confusing. OTOH, we can see skipped tests in -V mode (but I agree, that it isn't very convenient). I am open for discussion :). > > On 24.09.2024 13:29, Sergey Kaplun wrote: > > Profilers tests with LUAJIT_ENABLE_TABLE_BUMP are flaky due to the bug > > in the TDUP patching. Disable them for now. > > --- > > test/tarantool-tests/CMakeLists.txt | 6 ++++++ > > .../profilers/gh-5688-tool-cli-flag.test.lua | 2 ++ > > .../gh-5813-resolving-of-c-symbols.test.lua | 2 ++ > > .../gh-5994-memprof-human-readable.test.lua | 2 ++ > > ...7264-add-proto-trace-sysprof-default.test.lua | 2 ++ > > ...-9217-profile-parsers-error-handling.test.lua | 2 ++ > > .../profilers/misclib-memprof-lapi.test.lua | 16 +++++++++------- > > .../profilers/misclib-sysprof-lapi.test.lua | 2 ++ > > 8 files changed, 27 insertions(+), 7 deletions(-) > > > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > > test:plan(19) -- Best regards, Sergey Kaplun