From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EA60CEA8200; Tue, 24 Sep 2024 13:34:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EA60CEA8200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727174053; bh=hybonGtvLSQg9uRp36Img6SQdUgyJxP7NEX/h9MPAl4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=noO8IBSjZhCtjR4Aw6IBkLc3E0toRRM+cM9pHnb6qF8RMBRbc/fBZXVF1sG6leZDm ChwNqTZd6Yw+Zegw9z1oqmqmr0wiqkGHgOpy/tBAZfXyo5byQU+FCBQkOX4wyCD6XC QCF18iFxWN0C+xHNzXhNz7E0Suto8/fv1Hd8BZhg= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C5010E32078 for ; Tue, 24 Sep 2024 13:33:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C5010E32078 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1st2rZ-00000002pEV-1x8N; Tue, 24 Sep 2024 13:33:45 +0300 Date: Tue, 24 Sep 2024 13:33:30 +0300 To: Sergey Bronnikov Message-ID: References: <20240923112852.26851-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD941CBEC3D08EBAA0971DA4E6AFD7BE56DAC55D89031953764182A05F5380850404C228DA9ACA6FE27523D9788E125E87CF378A8CA21F699D6E97937EFB1AEC56A22B0630ED1A97E373C5A36B8DDD67158 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F65C230EDDCD559EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372F19B29C465B909E8F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566C3B4444CC64DE5DB7FB90E2E46452A5B91B89F5894EA155C801F7CA0D902BD82389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A29E2F051442AF778941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CE9959E2676FD87735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A59781ED2A819C6E885002B1117B3ED6967D5DDE845CB6CF8B69995D676B7B4CBE823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340FE9920E7E3E5C62D09B28ADD1C98AA1916790AF8211BF383D501470FBB86B46B8352099F6BB91441D7E09C32AA3244CDA7194CE35AC144A86B83C6DB07BF3AEC6DC5AAA010754B7EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojamSMdo1tbG95yJ9vGedMBA== X-DA7885C5: 3FB39AB6278D331AF255D290C0D534F9A1E9EBB8CEF7DFEF64F867246C89053BE5E031EF4B7BCC025B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B457C167C9CCAF5B2B830D6D429CA8A75107F9D5CA6315734E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Add missing coercion when recording select(string, ...) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 24.09.24, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! > > See minor comment below. > > LGTM > > > On 23.09.2024 14:28, Sergey Kaplun wrote: > > + > > +test:is(result, 1, 'corect select result after recording') > > s/corect/correct/ Fixed, thanks! =================================================================== diff --git a/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.lua b/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test. lua index 8089247f..5145efd5 100644 --- a/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.lua +++ b/test/tarantool-tests/lj-1083-missing-tostring-coercion-in-select.test.lua @@ -34,6 +34,6 @@ jit.opt.start('hotloop=1') -- XXX: amount of arguments is empirical, see the comment above. local result = test_select(1, 2, 3, 4) -test:is(result, 1, 'corect select result after recording') +test:is(result, 1, 'correct select result after recording') test:done(true) =================================================================== > > > > + > > +test:done(true) -- Best regards, Sergey Kaplun