From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 323E1C9EDCD; Mon, 23 Sep 2024 10:52:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 323E1C9EDCD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727077931; bh=MbNp33w0xbfJYFyVRZ7VYHuDYRSZmN3lctYEGpJLN1A=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=t12Thd+kTlrBU7etKaR62dO2rV0Mbq5IX24mWrCoqjWiW5RUnsYC1XgHEn/z1Rrj+ yalIHo3Xms1+48J62ZG6P+qYJ7waCbsgzjELjsyo9IVh6RLBL+RuVzQsqScBOF8RAa ydKNNxbEXTO1fWXS/fwvrm99Yadmu/B1xbSJXL70= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 34B95C9EDCA for ; Mon, 23 Sep 2024 10:52:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 34B95C9EDCA Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1ssdrZ-0000000GhuD-0oVq; Mon, 23 Sep 2024 10:52:05 +0300 Date: Mon, 23 Sep 2024 10:51:50 +0300 To: Sergey Bronnikov Message-ID: References: <8e15f637e54914192927a769f6a98f85b199844b.1727074292.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E52E9D942F25A5F2366B30561EFB5C97F115E186B3066B500894C459B0CD1B99F18B03C74D3A47540A02D48E7B53F4AC50588A4AD8FEC3325E0D44F30E573478472923344694FB0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE769BF540C95EF782EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379D15B32FCF98DF428638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AAFA42D0455B7AC40F440908D9A5F3417E771F73C8E35FEFCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063722796E68EDC28121D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED62991661749BA6B97735B341D7040ADD27A2B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B2FFDA4F57982C5F435872C767BF85DA227C277FBC8AE2E8B9EB32FE0C26A3A4C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A554BC663F3B378BCB5002B1117B3ED69674678A6D6BBF54A247A99E6294EE8661823CB91A9FED034534781492E4B8EEAD9DB614F8F96CFA30BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF17B17DC115585BDE28BFC487FC1E57AAEC9C7198BA7EF3B04CB6FA2B809559B69EC5AF04A575AA6CFD4E6A0B424C2B4891775356A6E79DDC9693CDAFEC89E8393088C2D515CE95D75F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojcsBYxvRMKeypRBcHVLR9Kg== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59A1020BF4D6553CD8479CDAE959BF6424AFB526C19F3188C6B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/7] test: move profilers tests to subdirectory X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 23.09.24, Sergey Bronnikov wrote: > Hi, Sergey > > > thanks for the patch! See a comment below. Updated the commit message. > > > On 23.09.2024 10:18, Sergey Kaplun wrote: > > It is useful when we want to change the properties for these tests only. > > > > Needed for tarantool/tarantool#9898 > > --- > > test/tarantool-tests/CMakeLists.txt | 10 +++++----- > > .../{ => profilers}/gh-5688-tool-cli-flag.test.lua | 0 > > .../gh-5813-resolving-of-c-symbols.test.lua | 0 > > .../gh-5813-resolving-of-c-symbols/both/CMakeLists.txt | 0 > > .../gh-5813-resolving-of-c-symbols/both/resboth.c | 0 > > .../gnuhash/CMakeLists.txt | 0 > > .../gnuhash/resgnuhash.c | 0 > > .../gh-5813-resolving-of-c-symbols/hash/CMakeLists.txt | 0 > > .../gh-5813-resolving-of-c-symbols/hash/reshash.c | 0 > > .../stripped/CMakeLists.txt | 0 > > .../stripped/resstripped.c | 0 > > .../gh-5994-memprof-human-readable.test.lua | 0 > > .../gh-7264-add-proto-trace-sysprof-default.test.lua | 0 > > .../gh-9217-profile-parsers-error-handling.test.lua | 0 > > .../{ => profilers}/misclib-memprof-lapi.test.lua | 0 > > .../{ => profilers}/misclib-sysprof-lapi.test.lua | 0 > > .../{ => profilers}/tools-utils-avl.test.lua | 0 > > 17 files changed, 5 insertions(+), 5 deletions(-) > > rename test/tarantool-tests/{ => profilers}/gh-5688-tool-cli-flag.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/both/CMakeLists.txt (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/both/resboth.c (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/gnuhash/CMakeLists.txt (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/gnuhash/resgnuhash.c (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/hash/CMakeLists.txt (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/hash/reshash.c (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/stripped/CMakeLists.txt (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5813-resolving-of-c-symbols/stripped/resstripped.c (100%) > > rename test/tarantool-tests/{ => profilers}/gh-5994-memprof-human-readable.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/gh-7264-add-proto-trace-sysprof-default.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/gh-9217-profile-parsers-error-handling.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/misclib-memprof-lapi.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/misclib-sysprof-lapi.test.lua (100%) > > rename test/tarantool-tests/{ => profilers}/tools-utils-avl.test.lua (100%) > > > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > > index 0bd3e6fc..11a84496 100644 > > --- a/test/tarantool-tests/CMakeLists.txt > > +++ b/test/tarantool-tests/CMakeLists.txt > > @@ -21,10 +21,6 @@ endmacro() > > add_subdirectory(ffi-ccall) > > add_subdirectory(fix-bit-shift-generation) > > add_subdirectory(gh-4427-ffi-sandwich) > > -add_subdirectory(gh-5813-resolving-of-c-symbols/both) > > -add_subdirectory(gh-5813-resolving-of-c-symbols/hash) > > -add_subdirectory(gh-5813-resolving-of-c-symbols/gnuhash) > > -add_subdirectory(gh-5813-resolving-of-c-symbols/stripped) > > Should we move these tests as well? > > test/tarantool-tests/lj-726-profile-flush-close.test.lua > > test/tarantool-tests/lj-512-profiler-hook-finalizers.test.lua > > > or did you mean only tarantool's profilers in commit message. Yes this one. > > Please clarify it in commit message if it is so. The new commit message is the following. Branch is force-pushed. | test: move profilers tests to subdirectory | | This patch moves tests for Tarantool's profilers like memprof and | sysprof to the corresponding subdirectory. | It is useful when we want to change the properties for these tests only. | | Needed for tarantool/tarantool#9898 > > > add_subdirectory(gh-6098-fix-side-exit-patching-on-arm64) > > add_subdirectory(gh-6189-cur_L) > > add_subdirectory(lj-416-xor-before-jcc) > > @@ -38,6 +34,10 @@ add_subdirectory(lj-flush-on-trace) > > add_subdirectory(lj-1004-oom-error-frame) > > add_subdirectory(lj-1066-fix-cur_L-after-coroutine-resume) > > add_subdirectory(lj-1166-error-stitch) > > +add_subdirectory(profilers/gh-5813-resolving-of-c-symbols/both) > > +add_subdirectory(profilers/gh-5813-resolving-of-c-symbols/gnuhash) > > +add_subdirectory(profilers/gh-5813-resolving-of-c-symbols/hash) > > +add_subdirectory(profilers/gh-5813-resolving-of-c-symbols/stripped) > > > > # The part of the memory profiler toolchain is located in tools > > # directory, jit, profiler, and bytecode toolchains are located > > @@ -121,7 +121,7 @@ add_test_suite_target(tarantool-tests > > > > file(GLOB_RECURSE tests ${CMAKE_CURRENT_SOURCE_DIR} "*${LUA_TEST_SUFFIX}") > > foreach(test_path ${tests}) > > - get_filename_component(test_name ${test_path} NAME) > > + file(RELATIVE_PATH test_name ${CMAKE_CURRENT_SOURCE_DIR} ${test_path}) > > set(test_title "test/${TEST_SUITE_NAME}/${test_name}") > > add_test(NAME ${test_title} > > COMMAND ${LUAJIT_TEST_COMMAND} ${test_path} > > diff --git a/test/tarantool-tests/gh-5688-tool-cli-flag.test.lua b/test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua > > similarity index 100% > > rename from test/tarantool-tests/gh-5688-tool-cli-flag.test.lua > > rename to test/tarantool-tests/profilers/gh-5688-tool-cli-flag.test.lua > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols.test.lua b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols.test.lua > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols.test.lua > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/both/CMakeLists.txt b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/both/CMakeLists.txt > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/both/CMakeLists.txt > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/both/CMakeLists.txt > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/both/resboth.c b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/both/resboth.c > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/both/resboth.c > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/both/resboth.c > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/gnuhash/CMakeLists.txt b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/gnuhash/CMakeLists.txt > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/gnuhash/CMakeLists.txt > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/gnuhash/CMakeLists.txt > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/gnuhash/resgnuhash.c b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/gnuhash/resgnuhash.c > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/gnuhash/resgnuhash.c > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/gnuhash/resgnuhash.c > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/hash/CMakeLists.txt b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/hash/CMakeLists.txt > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/hash/CMakeLists.txt > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/hash/CMakeLists.txt > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/hash/reshash.c b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/hash/reshash.c > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/hash/reshash.c > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/hash/reshash.c > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/stripped/CMakeLists.txt b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/stripped/CMakeLists.txt > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/stripped/CMakeLists.txt > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/stripped/CMakeLists.txt > > diff --git a/test/tarantool-tests/gh-5813-resolving-of-c-symbols/stripped/resstripped.c b/test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/stripped/resstripped.c > > similarity index 100% > > rename from test/tarantool-tests/gh-5813-resolving-of-c-symbols/stripped/resstripped.c > > rename to test/tarantool-tests/profilers/gh-5813-resolving-of-c-symbols/stripped/resstripped.c > > diff --git a/test/tarantool-tests/gh-5994-memprof-human-readable.test.lua b/test/tarantool-tests/profilers/gh-5994-memprof-human-readable.test.lua > > similarity index 100% > > rename from test/tarantool-tests/gh-5994-memprof-human-readable.test.lua > > rename to test/tarantool-tests/profilers/gh-5994-memprof-human-readable.test.lua > > diff --git a/test/tarantool-tests/gh-7264-add-proto-trace-sysprof-default.test.lua b/test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua > > similarity index 100% > > rename from test/tarantool-tests/gh-7264-add-proto-trace-sysprof-default.test.lua > > rename to test/tarantool-tests/profilers/gh-7264-add-proto-trace-sysprof-default.test.lua > > diff --git a/test/tarantool-tests/gh-9217-profile-parsers-error-handling.test.lua b/test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua > > similarity index 100% > > rename from test/tarantool-tests/gh-9217-profile-parsers-error-handling.test.lua > > rename to test/tarantool-tests/profilers/gh-9217-profile-parsers-error-handling.test.lua > > diff --git a/test/tarantool-tests/misclib-memprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua > > similarity index 100% > > rename from test/tarantool-tests/misclib-memprof-lapi.test.lua > > rename to test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua > > diff --git a/test/tarantool-tests/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > > similarity index 100% > > rename from test/tarantool-tests/misclib-sysprof-lapi.test.lua > > rename to test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > > diff --git a/test/tarantool-tests/tools-utils-avl.test.lua b/test/tarantool-tests/profilers/tools-utils-avl.test.lua > > similarity index 100% > > rename from test/tarantool-tests/tools-utils-avl.test.lua > > rename to test/tarantool-tests/profilers/tools-utils-avl.test.lua -- Best regards, Sergey Kaplun