From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 869C4CC8E81; Mon, 23 Sep 2024 09:57:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 869C4CC8E81 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1727074657; bh=YjRvRXTZADYWoGR9CLuiQv5iio/+n67n/Ty5x6DZw+c=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JRn3renf37I1E+ITz1Gtl8K7Eka+V8n8pgSBCWRzrVUInORiG9buQ7JQjGBiDhXrY ZtnoFEfxJcoGrktLQqA3UzOGmo+VFG6wZJa0I8ZB93rKiWG7Yh/NaTRrjaOwKI9uzr C0jOOp3SE+sZsvD+1CphGfkzP2IIYovaZfhe8ozA= Received: from smtp17.i.mail.ru (smtp17.i.mail.ru [95.163.41.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C5F5FCC8E81 for ; Mon, 23 Sep 2024 09:57:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C5F5FCC8E81 Received: by smtp17.i.mail.ru with esmtpa (envelope-from ) id 1ssd0p-0000000Egpv-3CTQ; Mon, 23 Sep 2024 09:57:36 +0300 Date: Mon, 23 Sep 2024 09:57:20 +0300 To: Maxim Kokryashkin Message-ID: References: <20240826123740.12759-1-skaplun@tarantool.org> <6xbb7bbda3bm7ryzzdovwq32wukphxi7aykr5wm3oxc3wsxxao@povjteevh5va> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6xbb7bbda3bm7ryzzdovwq32wukphxi7aykr5wm3oxc3wsxxao@povjteevh5va> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96E52E9D942F25A5FC234CDC635A19E357E9EDAF3D16295D600894C459B0CD1B995ECA140F13E8350EF9AB19871C209C10E0DFA5AE82AF66E582142BEC511D8731E35E39F85F323EC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F68DA2F3749BB650EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375189E43B47FB350A8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8191D597C35BCC72396C7A1E4E2E92FA6153DC3F7354C12EDCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063790495A4AD0498982D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE72B056A9979167638EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30584FF81F342DA0735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A590EE1516A19DF7CC5002B1117B3ED69600CF19158D90E8B7B74D9144D44E4FCF823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34D16EA493CC1FD9F80B1B2C4D35075163D4C6B461E780832563FD764BBFB0A5EFCA9400730C345E491D7E09C32AA3244CFD5252F681C68733B58A6D757C7509E27B56B2D889870AD3EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojcsBYxvRMKewE6dKawI6tzw== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59F2800470EE5251DC03ED270C30F246C51F0818989E5826EBB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix limit check in narrow_conv_backprop(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments and force-pushed the branch. On 23.09.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few nits below. > > On Mon, Aug 26, 2024 at 03:37:40PM GMT, Sergey Kaplun wrote: > > From: Mike Pall > > > > Thanks to Sergey Kaplun. > > > > (cherry picked from commit e45fd4cb713b610506213692f3b55a1869febb03) > > > > `narrow_conv_backprop()` misses the stack pointer (`nc->sp`) limit check > > after a bunch of recursive calls that may change its value. As a result, > It took me a minute to understand that sentence. Let's paraphrase it the > following way: > > | The function narrow_conv_backprop() does not include a limit > | check for the stack pointer (nc->sp), even though its value may > | change after several recursive calls. Rephrased as you suggested. The new commit message is the following: | Fix limit check in narrow_conv_backprop(). | | Thanks to Sergey Kaplun. | | (cherry picked from commit e45fd4cb713b610506213692f3b55a1869febb03) | | The function `narrow_conv_backprop()` does not include a limit check for | the stack pointer (`nc->sp`), even though its value may change after | several recursive calls. As a result, it leads to stack-buffer-overflow | during the instruction narrowing. This patch adds the missing check. | | Sergey Kaplun: | * added the description and the test for the problem | | Part of tarantool/tarantool#10199 > > > it leads to stack-buffer-overflow during the instruction narrowing. This > > patch adds a missing check. > Typo: s/a missing/the missing Fixed, thanks! > > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#10199 > > --- > > > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-1262-fix-limit-narrow-conv-backprop > > Related issues: > > * https://github.com/tarantool/tarantool/issues/10199 > > * https://github.com/LuaJIT/LuaJIT/issues/1262 > > -- Best regards, Sergey Kaplun