From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 66B02D75D00; Tue, 17 Sep 2024 15:01:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 66B02D75D00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1726574492; bh=ti26obpwB7oUrJpapOjbXq/NN1sWUNpJwKhBm/fPHqk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=r/+Xa5soz0ZySPFLV2sl7T11r/ILs74fy3B4AWOSvqAqVxkYJpfzi37jAakITVjSV UT97dBwQ+DYQlVGqNiT1QtrFYIOcQcZtiquRnoDfWid+Aplx6p2TfyOEM9dnMyhbNC hE/sENDBGYGRoc58yf/cHkBq0nCBdhAPWKCo3sFM= Received: from smtp17.i.mail.ru (smtp17.i.mail.ru [95.163.41.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 213BBD75D27 for ; Tue, 17 Sep 2024 15:01:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 213BBD75D27 Received: by smtp17.i.mail.ru with esmtpa (envelope-from ) id 1sqWtd-00000008HXE-3wNb; Tue, 17 Sep 2024 15:01:30 +0300 Date: Tue, 17 Sep 2024 15:01:17 +0300 To: Sergey Bronnikov Message-ID: References: <20240826123740.12759-1-skaplun@tarantool.org> <8178af4b-fa35-44c2-b3fd-6e563eb660d5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8178af4b-fa35-44c2-b3fd-6e563eb660d5@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD921D24E727BB09B71ABFF59349B874A20729D181E270439EA182A05F538085040F087BB1102B0F324C7A4B249DE6549FD2EA78881879E045C71D0FCE10E0DDA9B47D41910D6C19DC5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D77100FFB2844417EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D6424E594306CB78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D856F391620FD50022A291A264C2E3AEB112714E68CDBD0D2BCC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8A9FF340AA05FB58CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B53A69B3AC30C7B9475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5BF01E3B6A528040A5002B1117B3ED6966604236236936856361FAC1196A180DE823CB91A9FED034534781492E4B8EEAD4ECBDE8281F904F9BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F6110710A6CC527FB345B093E493FB2750BB9C2CB4E95A4907CA3D58BBC1EEB4A4EAC763DD41F84B1D7E09C32AA3244C5619974A79E34C613BA3F8B02A6D222BDBFE7166D2A3E27BEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojK9mC3H63xFbqgvrEXFeZrg== X-DA7885C5: 3C1BED337DFFE155F255D290C0D534F903711666FF04066CAA895F0FE81CEF9CB29E53A137CC725E5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BD291EA21CB2430910FD547F37D8FBB946CBF714F51AC3768E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix limit check in narrow_conv_backprop(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 17.09.24, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for tha patch! LGTM with a minor comment below. > > On 26.08.2024 15:37, Sergey Kaplun wrote: > > From: Mike Pall > > +-- XXX: Test fails only under ASAN. > > +-- XXX: The original reproducer was found by fuzzer: > > +--https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=70779. > > +-- It creates a long side trace with a huge amount of ADD IRs, > > +-- which are recursively used in the `narrow_conv_backprop()` many > > +-- enough times to catch the stack-buffer-overflow. I can't > > +-- simplify the reproducer any more (or write it from scratch), so > > +-- I leave it in that state. > > + > > I would remove a sentence "I can't simplify the reproducer ..." > > from the test, because it is useful information on review and > > I think it is useless for those who will use the test. I do not agree -- it is kind of worning to prevent changing the test. Also, we have something similar for gh-4199-gc64-fuse, for example. > > Feel free to ignore and leave as is. So, ignoring for now. > > > s/any more/anymore/ I decided to drop any, so the comment is the following now: =================================================================== diff --git a/test/tarantool-tests/lj-1262-fix-limit-narrow-conv-backprop.test.lua b/test/tarantool-tests/lj-1262-fix-limit-narrow-conv-backprop.test.lua index 6bb4025d..c225fa14 100644 --- a/test/tarantool-tests/lj-1262-fix-limit-narrow-conv-backprop.test.lua +++ b/test/tarantool-tests/lj-1262-fix-limit-narrow-conv-backprop.test.lua @@ -15,9 +15,9 @@ test:plan(1) -- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=70779. -- It creates a long side trace with a huge amount of ADD IRs, -- which are recursively used in the `narrow_conv_backprop()` many --- enough times to catch the stack-buffer-overflow. I can't --- simplify the reproducer any more (or write it from scratch), so --- I leave it in that state. +-- enough times to catch the stack-buffer-overflow. I can't more +-- simplify the reproducer any (or write it from scratch), so I +-- leave it in that state. local DEFAULT_NUMBER = 1 local tonumber = tonumber =================================================================== -- Best regards, Sergey Kaplun