From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0F9E3EB2C41; Mon, 16 Sep 2024 11:09:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F9E3EB2C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1726474185; bh=fxfy5oMZCdrrJvv6AEWgvROLszUsMgETIW35kczgql0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SodtiiJdp85ZQv4c/J/4irEiMyyjfUMAhgKzX5zB2UPS1hz+qC+vRD94L9Jh87SOe 4+QZAgqRBneaHr9Mm0iLI8WLhrP18ZUVtYX3Nz8GP4Oxlnt/y6a0jvt36TB3VZeC72 M3eA++drnw6ixmHhClIkvJ8+5twTtKtmMvLz4+n0= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 800E1EB2C41 for ; Mon, 16 Sep 2024 11:09:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 800E1EB2C41 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1sq6nl-00000008pRW-3yjF; Mon, 16 Sep 2024 11:09:42 +0300 Date: Mon, 16 Sep 2024 11:09:29 +0300 To: mandesero@gmail.com Message-ID: References: <20240912102153.163481-1-mandesero@gmail.com> <20240912102153.163481-3-mandesero@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240912102153.163481-3-mandesero@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9149934E261B3C8505020A264BA24971DE1EDD6ED5FA0EA04182A05F53808504084E5E1563FA30680C7A4B249DE6549FD1B1889F5214D02D9C5CDFC53FD7C8D2BD0AE7B500D4FFA5A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE771540F9ECFC94C4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F9CBC1404CDFA5A08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80B571CBD6D152AE0B7EAF348124369F78E1AF5D285037C41CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FCF1175FABE1C0F9B6E2021AF6380DFAD18AA50765F7900637F09814068C508CC822CA9DD8327EE4930A3850AC1BE2E735B58781B77DE60D36C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5310E7053099470185002B1117B3ED696224CB36443040DE8ED71F038FC046993823CB91A9FED034534781492E4B8EEADAEB4DDBFD72C8FA1BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34FACF503ACC83041B2FC14577715D7564F3AC62EF1BAD972DC4A9DECC54F9D4FE64899A917D8AD1CF1D7E09C32AA3244C03C8FF425B1542CA3BA3F8B02A6D222B9B996C1A9D5C2092EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnH7hiPSwZxAsfJBQFT5lLA== X-DA7885C5: 03D1AB5C2CE1F212F255D290C0D534F92E2829DB8FBA96C96403FF05883BDD519B4A73A35C4F4BD35B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BD3415A4C23F67F548A2E3CC7F39AE201FCB8143D8C008B4FE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 2/3] ci: add Valgrind testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maksim! Thanks for the patch! Please see my comment below. On 12.09.24, mandesero@gmail.com wrote: > From: Maksim Tiushev > + runs-on: [self-hosted, regular, Linux, x86_64] It is worth checking the arm64 architecture too. It is useful for backporting patches like the following: * 003f6856 ("FFI: Don't load PC from non-function object in FFI continuation.") [1], * 68ffbd31 ("FFI: Don't load PC from non-function object in FFI continuation.") [2]. See the corresponding issue [3]. So, for this patchset, you should backport the aforementioned patches first and add the valgrind check after. > + name: > > -- > 2.34.1 > [1]: https://github.com/LuaJIT/LuaJIT/commit/003f6856 [2]: https://github.com/LuaJIT/LuaJIT/commit/68ffbd31 [3]: https://github.com/LuaJIT/LuaJIT/issues/743 -- Best regards, Sergey Kaplun