From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5B841DAB189; Thu, 12 Sep 2024 13:16:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B841DAB189 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1726136218; bh=+7A83NlXDbcXJ6EQ9YZW+4tSYW7tFvKRQs1SIDvKDZ8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VZK20zucn89oj48dhFsfMuIEkb6Y4KZ33ca/PkOM/+sg6mA7Dt3O/ApFsMGUxjT2C Q1bPadIJe7tg0XXK5w1Vo/1sx+AKOOZVBYOH3jzU5mYFH1V7eKwCvSvBY9gbyTmXXJ tHb0QakbyBg697i5tdgcNjA7/fOCbDDokHLf2rlQ= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3FDF257BE00 for ; Thu, 12 Sep 2024 13:16:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3FDF257BE00 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1sogsh-00000001ZMy-0xag; Thu, 12 Sep 2024 13:16:55 +0300 Date: Thu, 12 Sep 2024 13:16:45 +0300 To: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <20240821165250.11087-1-skaplun@tarantool.org> <5f51a9ad-3302-4e0c-8d91-c5a26c147fe2@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91486559A3ABF84E7A3C7EB7E053E3B8DA2AD8C7EE44CDF4D182A05F538085040061BA2D231CAB4A99487ABAC94A94B5460276AA061C3C8AEB264E810EC88C4A2A035D568507C15B2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FE853634EDEBEC2EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A9545EB8D2325CAFEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F369EA854BDF8F1EF2C4015E196AFAB504430F60DBF35F4ED99A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE78C592797616C97AB9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F7900637F9425D8FA97DB4396D1867E19FE1407978DA827A17800CE773BC869C69ECC1572DBA43225CD8A89FB26E97DCB74E62525E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5EF7399D8459E44515002B1117B3ED696B7F2F58574C14719466072E6821086B3823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFC810927255074B568E6B7CB6CB9A07F0F327DAC2CA330B944AA8FA97743573184D6C1B221ADCA664BA3E0C39EEA44CB3F7EA37FEC1CAEEDD9CB1AFC6CE59AC4E5D274C9CD303FC60111DC66A97D0BFE2913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojBIBNH8BG++e5nqX9a4skJQ== X-DA7885C5: 9C6D9166C82FA532F255D290C0D534F9E63A9E6742DFAD100FEDEA96D3D6FDC285C8D729E12678CD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B00B174AFE655D0865D711AB703368C443D8BB626C5F17393E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] FFI: Fix various issues in recff_cdata_arith. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 10.09.24, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the review! > > On 10.09.24, Sergey Bronnikov wrote: > > Hi, Sergey, > > > > On 09.09.2024 18:37, Sergey Bronnikov via Tarantool-patches wrote: > > > > > > Hi, Sergey, > > > > > > thanks for the patch! see my comments below. > > > > > > On 21.08.2024 19:52, Sergey Kaplun wrote: > > >> From: Mike Pall > > >> > > > > > >> --- > > >> > > >> Branch:https://github.com/tarantool/luajit/tree/skaplun/lj-1224-fix-jit-cdata-arith > > >> Related issues: > > >> *https://github.com/tarantool/tarantool/issues/10199 > > >> *https://github.com/LuaJIT/LuaJIT/issues/1224 > > >> > > >> src/lj_crecord.c | 10 ++-- > > >> .../lj-1224-fix-cdata-arith-ptr.test.lua | 48 +++++++++++++++++++ > > > > > > This test does not fail without fix (but repro from the issue does): > > > > > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > > ./build/gc64/src/luajit -Ohotloop=1 -e " > > > repeat > > >   r = 1LL + nil > > > until true > > > " > > > LuaJIT ASSERT > > > /home/sergeyb/sources/MRG/tarantool/third_party/luajit/src/lj_ctype.c:185: > > > lj_ctype_intern: uninitialized cts->L > > > Aborted > > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > > ./build/gc64/src/luajit > > > test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua > > > TAP version 13 > > > 1..2 > > >     # cdata arithmetic with nil > > > 1..2 > > >     ok - correct recording error with bad cdata arithmetic > > >     ok - correct error message > > >     # cdata arithmetic with nil: end > > > ok - cdata arithmetic with nil > > >     # cdata arithmetic with string > > >     1..2 > > >     ok - correct recording error with bad cdata arithmetic > > >     ok - correct error message > > >     # cdata arithmetic with string: end > > > ok - cdata arithmetic with string > > > [0] ~/sources/MRG/tarantool/third_party/luajit $ > > > > > > > With GC64 only (LUAJIT_ENABLE_GC64). > > It don't fail with GC64? > > Should I add the comment? I've added the following comment to avoid the confusion. Branch is force-pushed. =================================================================== diff --git a/test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua b/test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua index 9de9586d..dd7e23ec 100644 --- a/test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua +++ b/test/tarantool-tests/lj-1224-fix-cdata-arith-ptr.test.lua @@ -11,6 +11,8 @@ local test = tap.test('lj-1224-fix-cdata-arith-ptr'):skipcond({ test:plan(2) +-- XXX: This test leads to the assertion failure before the patch +-- only for non-GC64 build. local function arith_nil_protected() local i = 1 while i < 3 do =================================================================== > > > > > -- > Best regards, > Sergey Kaplun -- Best regards, Sergey Kaplun