From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B72C7C0DB44; Mon, 26 Aug 2024 09:56:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B72C7C0DB44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724655402; bh=FaPZ9Z353jq/idhgeta9qH6snhUZy18aMsULjHTqmJA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=W5cAFC2UGaJnDYxk6YzRBSgLB8c3UzIfV4/NRzl58mcYMcwx6Hug7qUBZvuUcKcf7 sCPP9MmxUDQmO5EbU+8T8PjvL7/Wqxo6tyN+b1MiSW91L93hRtJyg5Ag4wDTCy6EpZ 9CMph7ssB3m8lA7G0bUnVaQTklmrJoBnm3P3b0qE= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 803A5C0DB41 for ; Mon, 26 Aug 2024 09:56:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 803A5C0DB41 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1siTea-0000000AmPI-1VnC; Mon, 26 Aug 2024 09:56:40 +0300 Date: Mon, 26 Aug 2024 09:56:34 +0300 To: Sergey Bronnikov Message-ID: References: <439d9b017029c16d49cb9cf40dec881d6a9697b3.1724228998.git.skaplun@tarantool.org> <58df164b-ebe1-4ebb-80ba-f8606ea3a1d6@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <58df164b-ebe1-4ebb-80ba-f8606ea3a1d6@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E628F8707461F590EFE1A3877E07D392E182A05F53808504080BA1602EE5A5122C591814E25D11F9F51C58CE5A797288CE7509BD1F261B1425DA22744184D0E97 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B7733D0215A2F71AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063761B0653E4D5FA7998638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C156AB218C6D6AD0257E92702A7F27F624ABD9D5AB3DACACCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC2EE5AD8F952D28FBE2021AF6380DFAD18AA50765F7900637B8FA30D9455089A722CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C8C09E0D7D2307825002B1117B3ED696D075BA215E62AC2F30C8F815570A3530823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF4178BBE7F2820B4F88D12C5A3D10724F5903CB54B5CD49C7BAFD2EEC95026CAF9DCE6E1EBC7C769E8CBD875B35315F9AEC757A5E15289C544D063374EE6C4706403C306943E6D6A65F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPokOeLnI1rvbmDMZG3IvEg== X-DA7885C5: CC9C6F0C972334F0F255D290C0D534F912989779DCF714289D482C1B94DD3F8F75EBFA53ECB5DBBE5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B1002A5AF218F3CA4507F04FCF553E6BAACC35B5C6A3C94B8E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 31/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 22.08.24, Sergey Bronnikov wrote: > Sergey, > > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch refactors the aforementioned test to make its code style > > closer to ours. > > > > Relates to tarantool/tarantool#9398 > > --- > > thanks for the patch! LGTM with a minor: > > probably line 10 needs more whitespaces: > > >      do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame > size. Fixed thanks! See the iterative patch below. =================================================================== diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua index 8aee57e3..d05d4402 100644 --- a/test/LuaJIT-tests/lang/gc_stack.lua +++ b/test/LuaJIT-tests/lang/gc_stack.lua @@ -7,7 +7,10 @@ do --- Marking sparse stack. else return t[k] -- Leaves holes in each frame. end - do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame size. + do + -- Ensure bigger frame size. + local a, b, c, d, e, f, g, h, i, j, k, l, m, n + end end}) local x = t[50] end =================================================================== > > > test/LuaJIT-tests/lang/gc_stack.lua | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua > > index cd3d8f90..8aee57e3 100644 > > --- a/test/LuaJIT-tests/lang/gc_stack.lua > > +++ b/test/LuaJIT-tests/lang/gc_stack.lua > > @@ -1,5 +1,5 @@ > > do --- Marking sparse stack. > > - local t = setmetatable({}, { __index=function(t, k) > > + local t = setmetatable({}, { __index = function(t, k) > > k = k - 1 > > if k == 0 then > > collectgarbage() -- Mark stack, including holes. -- Best regards, Sergey Kaplun