From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E9EA9CEC3BA; Mon, 26 Aug 2024 09:50:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9EA9CEC3BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724655045; bh=3ZnkUMI0svVUa/yj2GsfYlZIMEUmviWveMl+Jq8xSk8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HEUnxqtpItPO/+jOQ6xnX/cMbMssFJ45Dt1uIxQ3vM/h91I9YxSdzTui6VeV2bISp m5miugqosfTV/tjfnFdkmwOH5jX/E33F9zHGR1tmtCONKH8wjTD/CnnJTVtp1T0lk9 4MxEYpzY6G5UrqZb2qYe3k+1qG0PfAH56oiOoa+M= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [95.163.41.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1E931CEC3A1 for ; Mon, 26 Aug 2024 09:50:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1E931CEC3A1 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1siTYo-0000000FAp9-1RtF; Mon, 26 Aug 2024 09:50:42 +0300 Date: Mon, 26 Aug 2024 09:50:36 +0300 To: Sergey Bronnikov Message-ID: References: <3ed1e158692a9773e3122cfdb134107cd0415354.1724228998.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E31015FC5902C0B2438B46547866FC5B0182A05F5380850405E8E0878B9CDC2DA411046492FDDF8064B19585775100032E7509BD1F261B142B861A82AA393303C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6702EC5472AA0FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375755FB4B1C4484E08638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DEF7B1F01BEFE976A8AFE9ED1BA87A00E96696215043D403CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FCF1175FABE1C0F9B6E2021AF6380DFAD18AA50765F7900637F09814068C508CC822CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5FBFF3377BCA18A2A5002B1117B3ED6962B5A96B54CF167BBED71F038FC046993823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D346B222596F62B8FA959D3104DE76884625DB0A98FE52EB82D650B710C90DA2A258664258C2741E58B1D7E09C32AA3244C578396FEE34E05667215182CA7F2886068D7AF2ED39AB78BEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPokOeLnI1rvxBg5/fwz85Q== X-DA7885C5: 2B8ADD77BE85F53BF255D290C0D534F91253D895C05A31FA71D4612F215EEC5FC207B757CBCF37E85B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BCB767EAC2803607FC66097FE00DBC8739A49480AC358BEDBE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 21/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments and force-pushed the branch. On 23.08.24, Sergey Bronnikov wrote: > Sergey, > > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch moves the aforementioned test from the to the > > directory, includes it in , and names subtests. > > > > Part of tarantool/tarantool#9398 > > --- > thanks for the patch! LGTM with a minor comment > > diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua > > new file mode 100644 > > index 00000000..a995921e > > --- /dev/null > > +++ b/test/LuaJIT-tests/trace/jit_flush.lua > > + > > + > please remove excess newline Fixed, thanks! See the iterative patch below. =================================================================== diff --git a/test/LuaJIT-tests/trace/jit_flush.lua b/test/LuaJIT-tests/trace/jit_flush.lua index a995921e..4cdf2c39 100644 --- a/test/LuaJIT-tests/trace/jit_flush.lua +++ b/test/LuaJIT-tests/trace/jit_flush.lua @@ -52,7 +52,6 @@ do --- Flush in the loop. jit.flush() end - do --- Flushes of not existed traces. jit.flush() =================================================================== > > +do --- Flushes of not existed traces. > > + jit.flush() > > + > > + jit.flush(1) -- ignored > > + jit.flush(2) -- ignored > > + for _ = 1, 1e7 do end -- causes trace #1 > > + > > + jit.flush(2) -- ignored > > + jit.flush(1) -- ok > > + jit.flush(1) -- crashes > > +end -- Best regards, Sergey Kaplun