From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C234DCEC3AA; Mon, 26 Aug 2024 09:39:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C234DCEC3AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724654378; bh=0/5N2eV53OJuCY64iF2SGyDiNrZaKlMBlkOAe9BfDHo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=a4TgQvNAQSPzxvUzjReHM7KzLqfOMtU1TLYxpv+O9Qhnjh8D2u3Ny3CR719KGy9RJ DVgXdA2+WSw5dYP3cT3Hgvdc/8ma8Sc8XYrAy6Al5gcRNPA8xbQhaqe4lKiEM840X5 nXaTZS7AHzg9qzbjQgg6KctLgeXJj8L7PxhSc2ng= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B022BCEC3A1 for ; Mon, 26 Aug 2024 09:39:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B022BCEC3A1 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1siTO4-0000000BHF5-3Q30; Mon, 26 Aug 2024 09:39:37 +0300 Date: Mon, 26 Aug 2024 09:39:31 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9604F665CF1C84C299E6D8E1CC684B50B3F077263C41BE8DD182A05F5380850404C228DA9ACA6FE27F5FE4BBED2360ADF33594132A326AF8B64A6AA30C8CA45546D98E27BF1888309954A11D17F55FE80 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CD8995A08F41566CEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36CB7D594603D53F6DC6235C05CCDB3545E01E5B74882FD51DA471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7328B01A8D746D8839FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F0A35B161A8BF67C135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A50F9EABA96630BCD85002B1117B3ED696A82AB42EA66632D24869453249F34FA4823CB91A9FED034534781492E4B8EEAD9DB614F8F96CFA30BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D340EEB18E491831571EAB47A15F29B3E905D699EF28DEE315301BC41786B347DA7A9FEC01CB3723C0B1D7E09C32AA3244CFE311235B97883F87B0DC8E7D22A103AC79FCB26D0A6D991EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPokOeLnI1ruq8OiYlSkG8Q== X-DA7885C5: 926A1FB62B7EBB13F255D290C0D534F9DC2540415AC1BA2C8CF6F384CE481B3E398B177A50EC76055B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BFB2E0859281C1697E46C4CBEFDBDFE441948E10D40AE4EE9E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 17/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the review! Please, consider my answers below. On 23.08.24, Sergey Bronnikov wrote: > Sergey, > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch moves the aforementioned test from the to the > > directory, includes it in , names the subtests, and adjusts the > > line numbers in the assertions and filters to match LuaJIT behaviour and > > the new code layout. Also, it slightly refactors the code to make it > > closer to our code style. > > > > Part of tarantool/tarantool#9398 > > --- > thanks for the patch! LGTM with a minor comment. > > +do --- Base test: cycles, function calls. > > + debug.sethook(hook, "l", 0) > > + -- <-- line 12 > > + local x > > + dummy() > > + local y = 1 > > + dummy() dummy() > > I would place a second call to a separate line. Feel free to ignore. I guess this tests the line number to return (16) here, see the expected array with line numbers below. > > > > > + local z = 2; local r = true > > + while y < 4 do y = y + 1 end > > + while z < 4 do > > + z = z + 1 > > + end > > + -- <-- line 22 > > + local v > > + debug.sethook(nil, "", 0) > > + > > + assert(#lines > 0) > > + while lines[1] < 12 do table.remove(lines, 1) end > > + while lines[#lines] > 22 do table.remove(lines) end > > + > > + local s = table.concat(lines, " ") > > + assert(s == "13 14 8 15 16 8 8 17 18 18 18 18 19 20 19 20 19" or > > + s == "13 14 8 15 16 8 16 8 17 18 18 18 18 19 20 19 20 19") -- Best regards, Sergey Kaplun