From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A74ECC5B2F0; Thu, 22 Aug 2024 17:37:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A74ECC5B2F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724337420; bh=ZqzM+9zzsOn9rO70+YacRlYZmEf8We/gO+4rdkhrbMI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=c/9SBE1N1ql4oKzFzv3vCuJK+JtpxVEi3Vi3MTZymd6uoPScqt8J8aQUf9BBqj8MF h8ocmMvlK7JdzM8WppluKzacgP9ieoMo6SdUGgxl3CMh3S915YusrlVMtf3NHYEx/p O2BdPfwbKpXzfZkiQlvVwDxr/PrB6EO723jQAkCc= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9BE1EC5B2F0 for ; Thu, 22 Aug 2024 17:36:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9BE1EC5B2F0 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1sh8vp-000000098dm-1kN6; Thu, 22 Aug 2024 17:36:57 +0300 Date: Thu, 22 Aug 2024 17:36:50 +0300 To: Sergey Bronnikov Message-ID: References: <1f20f349-f23d-4bdd-9227-c106bfa691f9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f20f349-f23d-4bdd-9227-c106bfa691f9@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9EC61F0D3869ED2E5C16BB8F7796F9D52D182A05F5380850409B67128F1C593EBE5D1BE6A8D71B10A5D84347AD5B4C5E97899CA9E4233F3A8D4634D9B51EFD7DC0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE74FC7AD0AD96C1577EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F3628363A0A84E6523A81500B9610BA47FB7C5596D7E303C652A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F7900637A451E1E29F2EDBED6D1867E19FE1407978DA827A17800CE7649B83402744A6742DBA43225CD8A89FB26E97DCB74E62526D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5D88758521B5D87DC5002B1117B3ED696AD2B7FFBE29D39E17E0012C66AE17B00823CB91A9FED034534781492E4B8EEADA79578C5CF9A9009BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6C999B75209E406DAFC56B61410564AEB75C4894E006ACB243B98E903E58C2A545D21F2230575A0F2FB0CAD32ADFBF8411F23EE9D404C33B85C884A24EB7FE54AF7A63C7E79644305F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XqHqZXLALYu1g== X-DA7885C5: AC5724BF1C541A41F255D290C0D534F9F4FFB59ABA8F1EA56E35CBBEA20FC2DE57BCEEFAEC919BF85B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BEB6E74A49919FE002FE4658EDF17049B4AF260D039D4BEF7E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 35/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 22.08.24, Sergey Bronnikov wrote: > Sergey, > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch moves the aforementioned test from the to the > > directory (with slightly renaming to be consistent with other names), > > includes it in , and names the subtest. > > > > Part of tarantool/tarantool#9398 > > --- > thanks for the patch! LGTM with comment below. > > test/LuaJIT-tests/lang/index | 1 + > > test/LuaJIT-tests/lang/stackov_c.lua | 12 ++++++++++++ > May be "stackoverflow_coro.lua"? I suppose the main idea is the possible stack overflow in the C function (more accurate built-in function) `unpack`. I prefer to leave the old name to avoid confusion. > > test/LuaJIT-tests/misc/stackovc.lua | 4 ---- > > 3 files changed, 13 insertions(+), 4 deletions(-) > > create mode 100644 test/LuaJIT-tests/lang/stackov_c.lua > > delete mode 100644 test/LuaJIT-tests/misc/stackovc.lua > > > > diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index > > index fa6db3c3..8da748d0 100644 > > --- a/test/LuaJIT-tests/lang/index > > +++ b/test/LuaJIT-tests/lang/index > > @@ -18,6 +18,7 @@ modulo.lua > > concat.lua > > self.lua > > stackov.lua > > +stackov_c.lua > > table.lua > > parse_comp.lua > > parse_esc.lua > > diff --git a/test/LuaJIT-tests/lang/stackov_c.lua b/test/LuaJIT-tests/lang/stackov_c.lua > > new file mode 100644 > > index 00000000..cea1a09e > > --- /dev/null > > +++ b/test/LuaJIT-tests/lang/stackov_c.lua > > @@ -0,0 +1,12 @@ > > +do --- Too many results to unpack. > > + local j = 1e4 > > + local co = coroutine.create(function() > > + local t = {} > > + for i = 1, j do > > + t[i] = i > > + end > > + return unpack(t) > > + end) > > + local ok, err = coroutine.resume(co) > > + assert(not ok and string.find(err, "unpack")) > > +end > > diff --git a/test/LuaJIT-tests/misc/stackovc.lua b/test/LuaJIT-tests/misc/stackovc.lua > > deleted file mode 100644 > > index c00bcbd8..00000000 > > --- a/test/LuaJIT-tests/misc/stackovc.lua > > +++ /dev/null > > @@ -1,4 +0,0 @@ > > -local j = 1e4 > > -local co = coroutine.create(function() t = {} for i = 1, j do t[i] = i end return unpack(t) end) > > -local ok, err = coroutine.resume(co) > > -assert(not ok and string.find(err, "unpack")) -- Best regards, Sergey Kaplun