From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1A82AC5B2EC; Thu, 22 Aug 2024 17:34:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1A82AC5B2EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724337288; bh=PxICu/aFY3OPR8KCpwBB0d0gSUmfACFjT0LzZ6MpqMs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FKh68HRTHTO0Yd3iI4PTs1j0fOZtZ2kTPdyu+tBUvFKaBNlTvHneiBn1rgX0rtwIc HQcpkrpfraf0QkEwP1cP0PJYppEcbY/rb4LzUknmhefw8/hZdbCpnaq7xwSAerUgH1 9qotTPB06EElaQYnR2aOKkrtL4YXUW3COd4pMCaI= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 883FBC5B2E1 for ; Thu, 22 Aug 2024 17:34:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 883FBC5B2E1 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1sh8th-0000000A8t4-1WV9; Thu, 22 Aug 2024 17:34:45 +0300 Date: Thu, 22 Aug 2024 17:34:38 +0300 To: Sergey Bronnikov Message-ID: References: <358fec19-25ee-49c2-a6a8-d40b999a92f5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <358fec19-25ee-49c2-a6a8-d40b999a92f5@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E988EDBF7D8158B96DA772C8D70101687182A05F538085040BA604977320EFBD2C591814E25D11F9F0B3D0F40275C6004899CA9E4233F3A8DE92FE53D5AEB5747 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7AB5815F4DE05345AEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F360C3EFC0CFD5FD1B9F6800B1BFDD391B0E7CBDE0116606215A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7850F8B975A76562C9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E62526D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5F3CCB5D144C09D555002B1117B3ED69691D680395AE64392559C6C5561145D6F823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F38194B2C99DC12840EF643B8E923A9B2AC7F9591F2ABAFA7EEDE20DF655FE7DFBAE21ABE4CD95E11D7E09C32AA3244CD9A66178DCB9C67FEBBA027F22CEDE66F277261E4BEE21D3EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XpNkVZVZ+t77Q== X-DA7885C5: FE7C858405778F05F255D290C0D534F9B4F13EDC124BBC2EE22A1544598A058DAE515739C43CEAC05B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B946DC7FDB603893C6379C9651FE670179C3D55EB061549FEE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 34/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answer below. On 22.08.24, Sergey Bronnikov wrote: > Sergey, > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch moves the aforementioned test from the to the > > directory, includes it in , names the subtests, and adds testing > > of the error message for all non-tail call cases. > > > > Part of tarantool/tarantool#9398 > > --- > thanks for the patch! LGTM with a minor comment below. > > test/LuaJIT-tests/lang/index | 1 + > > test/LuaJIT-tests/lang/stackov.lua | 48 ++++++++++++++++++++++++++++++ > Probably filename "stack_overflow.lua" will be better. Feel free to ignore. I prefer to leave it as is, since it is consistent with the error name in sources, if you don't insist. > > test/LuaJIT-tests/misc/stackov.lua | 40 ------------------------- > > 3 files changed, 49 insertions(+), 40 deletions(-) > > create mode 100644 test/LuaJIT-tests/lang/stackov.lua > > delete mode 100644 test/LuaJIT-tests/misc/stackov.lua > > -- Best regards, Sergey Kaplun