From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 15BFAE8C886; Thu, 22 Aug 2024 15:57:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 15BFAE8C886 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724331466; bh=v9ww/vNf6zW7mEMEJicLf8BvUY4nlFiCFWRONbZuShQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sSm2GRBP+ugsZkH8z2BBr9GGfttPkach74QN6e/XGzcsXTHYNOdYSyieG9SZ8Hd+y iqqpp78h/BtF3V/Gj2XMxH6KHuVX1SloAE+S45hGQ2RnAWWeetBQao6qN844FJVsaR Vo1/+Kt5hcaXKvqrGutRibNxFVcGU2ttIWDkg/e8= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [95.163.41.88]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 64C92E8C886 for ; Thu, 22 Aug 2024 15:57:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 64C92E8C886 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1sh7Nn-0000000EK64-0qvB; Thu, 22 Aug 2024 15:57:43 +0300 Date: Thu, 22 Aug 2024 15:57:36 +0300 To: Sergey Bronnikov Message-ID: References: <364dac6837a1a1a7247c9cb375a6da8771d3c050.1724228998.git.skaplun@tarantool.org> <7796fd5b-31a0-4d23-979d-a2feeb508478@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7796fd5b-31a0-4d23-979d-a2feeb508478@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9604F665CF1C84C299E6D8E1CC684B50B3F077263C41BE8DD182A05F5380850404C228DA9ACA6FE27AFC3C5B3B582778A03ED270C30F246C5F9520ED05D3A44DED4DC6FD71ABAF02C9B63AE8E64546DAE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372094AD700861FA748638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8415000FBDD3A63A4BB4CA30956679E04B87EC9219B0CFB54CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735BA6625F88748EAEFC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5C2892182B52266085002B1117B3ED696C2FCB6E1132BEFF5406406D89DD9EB8A823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C264B329661203DA39F7627C23CDAA05B03B217C023A19194B1516459C128001C4CB17C3844C0D801D7E09C32AA3244C2340E5DC0CADB8E4B58A6D757C7509E2182FC326982741E5EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XoTtFfglTNIGQ== X-DA7885C5: E80E5636DF12422BF255D290C0D534F96D705A51BE9C5CAAAD29AF61D4F5EBBBC490AAD5099FB2DA5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BD51D54D8434D4F19338F04FB21FAD8AE14B321339E258E4DE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 15/45] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! See my answers below. On 22.08.24, Sergey Bronnikov wrote: > Sergey, > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch moves the aforementioned test from the to the > > directory (with slightly renaming to be consistent with other names), > > includes it in , and names the subtests. > > > > Part of tarantool/tarantool#9398 > > --- > > thanks for the patch! Please adjust a width of lines in commit message. The commit message is already adjusted correct: the maximum width is 72 symbols (see [1]). Or what do you mean? > > LGTM > [1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message -- Best regards, Sergey Kaplun