From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A0628C634DE; Wed, 21 Aug 2024 19:36:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A0628C634DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724258202; bh=YuiJBgilRSN4lo9F5zJoTI1SAqSIv625iq9oU5zboAc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DBqV9Q//qy8N0e1NSYjrcS3uTXKl4wnWPMFnoRtQ9NN9pmUEJVvLev+Guh/oWI1bY vd5hJaLNFrhA6apIZFEMssZKWFojDLbIBiO+w6qPR8QBNO/FLCLfZ14eTudZWtaWb/ 0XWGULYRsBLm7x2da219zSAwuoVygivCjUyNMibc= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 462CAC634DE for ; Wed, 21 Aug 2024 19:36:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 462CAC634DE Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1sgoK7-0000000B73X-3LGP; Wed, 21 Aug 2024 19:36:40 +0300 Date: Wed, 21 Aug 2024 19:36:33 +0300 To: Sergey Bronnikov Message-ID: References: <1c96fa3b26cf05abef360b674d241f5c2a2208ca.1724228998.git.skaplun@tarantool.org> <49236ef7-cc89-4508-b6f8-d79c20ff24b1@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49236ef7-cc89-4508-b6f8-d79c20ff24b1@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9BB2AFC06FD50F0EFF118A8941B7B851F1B8D683A724D54F9182A05F538085040816561F2E5EABB0433594132A326AF8B3B9FF50B86C6F3789A4E95D55E331DAFFD50102C7C5B78F1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83AA3A0569E90685AC3E837573B13C667BF84F8DD5B4F02A7CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352629B07FD02F83A6C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5DC9F5D1E0AE50E945002B1117B3ED696C55CDFA4AA85D7A722DFD5397F446790823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3438BC6CF312DA73155C3C9459C45B8971131844D88A5E18F806AB6A514B1F609197AB70F0E2B6F58E1D7E09C32AA3244CF88BB562BEBD61447B0DC8E7D22A103A9D0E7B7D3D00FAF7EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojegttVMu7AX+KTbNG3ztUIQ== X-DA7885C5: 61EE5E82D45F7261F255D290C0D534F99C2F3F2FB7F3566575E80D52F0117B7C109AE51D6D1836755B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BD63C852168764068375C6B94EE80C4397F25D43619B7BE0EE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/45] test: remove LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 21.08.24, Sergey Bronnikov wrote: > Sergey, > > thanks for the patch! > > On 21.08.2024 11:58, Sergey Kaplun wrote: > > This patch removes the aforementioned test since it is identical to the > > Line's width is 70 symbols, please split. The maximum line's width is 72 symbols, see [1]. It is 71 here, so ignoring. Side note: I use (if not forgot) the Vim auto-formatting for the gitcommit. For the code style, it needs some tuning and configuration. :help v_gq > > LGTM > > > test, which wasn't cleaned up during the > > refactoring in the original repository. > > > > Part of tarantool/tarantool#9398 > > --- > [1]: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message -- Best regards, Sergey Kaplun