From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B8520C3E6A9; Mon, 19 Aug 2024 11:47:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B8520C3E6A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724057238; bh=xN5KwPBHtFr0XEcKa9h9BfWXDvIE/HAG9c64szqu0D8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DWJ+oBc0sAbBcXjIfliJx2b+u+3AbEl2eyoeE3jf4hyi+smUvr+qWmyDjS0pc8em1 WTsVet59DeD0eTcy4YZLi+4rMgW19iEseX7OTlH5ERQTaMelk+SOAZawZtCpMNJBk7 kSupdkuLIsuSjcFFjITdG2mNhm7HqyeQsVE2iEUE= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 01954C3E681 for ; Mon, 19 Aug 2024 11:47:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 01954C3E681 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1sfy2l-00000005PeB-18vM; Mon, 19 Aug 2024 11:47:15 +0300 Date: Mon, 19 Aug 2024 11:47:09 +0300 To: Sergey Bronnikov Message-ID: References: <7b92a28d-65b9-4322-9d4f-cee73959dbef@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7b92a28d-65b9-4322-9d4f-cee73959dbef@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9F97E3C14763C38E29560722C55467F34015AC91CD8757DC5182A05F5380850402C3015F6C3A4D372D27678DDAA806314D20603317B9690D41EB822A5E7259B74C9EA2F84C7A79467 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AEF9C2E372EE2CB3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F0D8FAB78312C5B48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C65775DAE548C47AC6E4838F8FD5AEBA8C29369270A7204BCC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A504F6C098F1F45B165002B1117B3ED69680B4D325B03750CE1BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34C974B02B4EA30DFBB586931EFCC6A4F9BD07604863E26FA6B4F6BC60EBB6D88FCA46AFED84FE9EC81D7E09C32AA3244CB7A31A30F760982E2887F5EA2DDCF3444C748F7B261A20C7EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxd0rRjfnTmYLwVGcRAJTsw== X-DA7885C5: 9D21F00FB048A9F7F255D290C0D534F9C3D9F14F1DB13581A4944087291219FA4ECE78E3A67D76755B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BF4D146F7C3E27CFCF09AFA434CA58DDE60E313285DF2E5DCE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 01/36] test: don't run JIT-based LuaJIT tests without JIT X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 15.08.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch, LGTM. > > See a minor comment below. > > > Sergey > > On 14.08.2024 16:55, Sergey Kaplun wrote: > > COMMAND ${LUAJIT_TEST_COMMAND} ${CMAKE_CURRENT_SOURCE_DIR}/test.lua > > - +slow +ffi +bit +jit ${LUAJIT_TEST_TAGS_EXTRA} > > + +slow +ffi +bit ${LUAJIT_TEST_TAGS_EXTRA} > > LUAJIT_TEST_TAGS_EXTRA is a list and to convert CMake list to a > whitespace-separated strings > > a list should be put in double quotes. > > However, I've run tests with options for avx512 and -DLUAJIT_NO_UNWIND=ON > > and passing test flags works fine without double quotes. With double quotes, these flags would be treated as "+jit +avx512" instead of separate flags +jit +avx512, so I leave it as is. > > > WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} > > ) > > set_tests_properties("${test_title}" PROPERTIES -- Best regards, Sergey Kaplun