From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1F6F9CA655A; Mon, 12 Aug 2024 16:17:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1F6F9CA655A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1723468642; bh=6681xhsesr+45sw2RHucjhlHBeRe41UUiFz+yckVxl0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sPY8lAVe0oRhxLgfYAskFWxs6Q7WBx7+3QdsxGYY+LgIJ+5KQsygYcoNd0oAPgb5c LrSlAAOagZtcyTHO1fYJtFibET9rd1M/WuQcW5hNErzZq/qT2Ly4aJIzG14MhmPAVd nXbVcTrxgLkrkekOsRhKpCOxturNMELnuQZ5O+Wg= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [95.163.41.64]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EA2B7CA6540 for ; Mon, 12 Aug 2024 16:17:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EA2B7CA6540 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1sdUvH-00000004a8p-0k7Q; Mon, 12 Aug 2024 16:17:19 +0300 Date: Mon, 12 Aug 2024 16:17:14 +0300 To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Message-ID: References: <43db36be-eb47-48ce-bec8-7326f3f9f24e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <43db36be-eb47-48ce-bec8-7326f3f9f24e@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90E4B1D041588DA6EE6BFE58C9E6B6C1B8FF96D2736B7DC7F182A05F538085040993CF79A3F9224D2D4FF92D56319F197F05A19D115AA38FF7634D20508538D810B379AF87BB1B6F5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DAE863916B47044D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8FAE39E517741A09A258931E8A71D3812FD3D89FB3A396208CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637ADD24768864FBB59D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE79ABE0BA893032164EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5278DA827A17800CE7A03E8F3C2D3812562EB15956EA79C166176DF2183F8FC7C0444A83B712AC0148725E5C173C3A84C3DD19ECFA348986C535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A599D52496A18CCFEA5002B1117B3ED696101939C3FC721E6BB74D9144D44E4FCF823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFFA45315ED7312BCD2F1D4703798E90A93E42FE4B51D4354E447085C871145982760962882471415BBC652F8AF4DDD5B7A443460364AAFD347F55A9085A198C0F1CA990B19CB2FC895F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbYjv4KtHp4GS1e4wRlZPWw== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59C6805A9E5E981FB0D4FF92D56319F197F05A19D115AA38FFB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2][v2] FFI: Turn FFI finalizer table into a proper GC root. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! On 23.07.24, Sergey Bronnikov wrote: > Hi, Sergey, > > fixes applied and force-pushed. > > Sergey > > On 10.07.2024 17:08, Sergey Kaplun wrote: > > Hi, Sergey! > > Thanks for the fixes! > > LGTM, after fixing minor comments below. > > > > On 10.07.24, Sergey Bronnikov wrote: > >> Hi, Sergey > >> > >> thanks for review. Fixes applied and force-pushed. > >> > >> Sergey > >> > >> > >> On 09.07.2024 15:14, Sergey Kaplun via Tarantool-patches wrote: > >>> Hi, Sergey! > >>> Thanks for the patch! > >>> Please consider my comments below. > >>> > >>> On 09.07.24, Sergey Bronnikov wrote: > >>>> diff --git a/test/tarantool-c-tests/lj-1168-heap-use-after-free-on-access-to-CTState-finalizer.test.c b/test/tarantool-c-tests/lj-1168-heap-use-after-free-on-access-to-CTState-finalizer.test.c > >>>> index c388c6a7..259528cb 100644 > >>>> --- a/test/tarantool-c-tests/lj-1168-heap-use-after-free-on-access-to-CTState-finalizer.test.c > >>>> +++ b/test/tarantool-c-tests/lj-1168-heap-use-after-free-on-access-to-CTState-finalizer.test.c > >>>> + int res = luaL_loadbufferx(L, buff, sizeof(buff) - 1, "chunk", "t"); > > I suggest renaming "chunk" to the "test_chunk" here too. > > Fixed, but after this the line becomes longer max length and I need to > split it for two lines: > > --- a/test/tarantool-c-tests/lj-1168-unmarked-finalizer-tab.test.c > +++ b/test/tarantool-c-tests/lj-1168-unmarked-finalizer-tab.test.c > @@ -83,7 +83,8 @@ unmarked_finalizer_tab_gcmark(void *test_state) >         /* Not trigger GC during `lua_openffi()`. */ >         lua_gc(L, LUA_GCSTOP, 0); > > -       int res = luaL_loadbufferx(L, buff, sizeof(buff) - 1, "chunk", "t"); > +       int res = luaL_loadbufferx(L, buff, sizeof(buff) - 1, > +                                  "test_chunk", "t"); >         if (res != LUA_OK) { >                 test_comment("error loading Lua chunk: %s", > lua_tostring(L, -1)); >                 bail_out("error loading Lua chunk"); > > I would leave "chunk" due to this. And you? OK, let's leave it as "chunk" in both places. > > > > > > Also, please add here comment about `sizeof(buff) - 1` too. Please add a comment that the terminating '\0' is considered by parser as part of the input, so we must chomp it. > > -- Best regards, Sergey Kaplun