From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CB98DC12ECE; Thu, 4 Jul 2024 11:40:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB98DC12ECE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1720082438; bh=rrX7ydzx3TuDwI4g9vgxnVqZdyoUgjCJqfMeuPd0VbY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mXeuDu4ul6J/o+8yve07ywoj9PcLqZNMpyuKKL5r2aYzXc6Gsw7cEAyDpRbJ7Wbrx o+at0FtW9+eYApoej1QsMU9tTpL20RbPOkFBehwI/0KpdsNNHztJ1iZImaqNrbYYro Iy3piraM34mF3BWlNx30VLSmMO/liElAVYavV0os= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4DBB2C12EC0 for ; Thu, 4 Jul 2024 11:40:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4DBB2C12EC0 Received: by exim-smtp-84f7fbf7d8-kd8m7 with esmtpa (envelope-from ) id 1sPI17-000000009vO-1C9Q; Thu, 04 Jul 2024 11:40:37 +0300 Date: Thu, 4 Jul 2024 11:40:31 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9E6DEAB84015E6B49A65F633FCB6A872BE932A1E9756CCCDA182A05F538085040B287C7671663E6503DE06ABAFEAF6705FB32941A4D57C25A09B0B2B744EACC7AB4427F3AD7048003 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75644E22E05AA81AEB287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF23F8577A6DFFEA7CCC517EB18D671D938F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566277CB9B6DFB1737DDC9E6748D8FF0F9D0E29E94C455373B11766A628EA661848389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C05A64D9A1E9CA65708941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6042F1592492B88C6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7994FE22CF3C16DE0731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5C7EA12622C78298F5002B1117B3ED6968D729E1C8D16429DB74D9144D44E4FCF823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFF850A31051537B77554CF1F3AC2488D83D6DFCA03CFAB2F8C1EB8F3BF008CE7245D21F2230575A0FCABF58F1CDB0D7D1ABD11B4E9BD5329B2FABDEE21C657A3A491D87F105CD8F0F5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj2Rj/U0IvFapvKtS5Hohb4w== X-DA7885C5: 830F8607799DD4C2F255D290C0D534F90C8815C6F72BB27E7B49BED9EFEE83FFB25F346452F741F55B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B929297976279BAD046AABEE531F11D95DC3DA9E6662DBAEEE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] Avoid negation of signed integers in C that may hold INT*_MIN. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comments rebased to the tarantool/master and force-pushed the branch. On 04.07.24, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with nit below > > > On 25.06.2024 18:54, Sergey Kaplun wrote: > > From: Mike Pall > > diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua > > new file mode 100644 > > index 00000000..26f4ed8e > > --- /dev/null > > +++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua > > @@ -0,0 +1,121 @@ > > +local tap = require('tap') > > + > > +-- Test file to demonstrate LuaJIT's UBSan failures during > > +-- `INT*_MIN` negation. > > +-- See also:https://github.com/LuaJIT/LuaJIT/issues/928. > > + > > +local test = tap.test('lj-928-int-min-negation.'):skipcond({ > > dot could be omitted in a test's name. Fixed, thanks! =================================================================== diff --git a/test/tarantool-tests/lj-928-int-min-negation.test.lua b/test/tarantool-tests/lj-928-int-min-negation.test.lua index 982bba73..bdf7e4f0 100644 --- a/test/tarantool-tests/lj-928-int-min-negation.test.lua +++ b/test/tarantool-tests/lj-928-int-min-negation.test.lua @@ -4,7 +4,7 @@ local tap = require('tap') -- `INT*_MIN` negation. -- See also: https://github.com/LuaJIT/LuaJIT/issues/928. -local test = tap.test('lj-928-int-min-negation.'):skipcond({ +local test = tap.test('lj-928-int-min-negation'):skipcond({ ['Test requires JIT enabled'] = not jit.status(), }) =================================================================== > > -- Best regards, Sergey Kaplun