From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C661ABD3DF1; Mon, 1 Jul 2024 12:33:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C661ABD3DF1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1719826425; bh=36FaHWFh5cmaiTyDGZ7hq4Zf1HsihiQEomN9h9OtfeA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uwQU2UDM5KuA6LuD/gzrSwigwqUMbM94Ul6eJI73NCFbd5A6XsFfmfKp0cTDnApcp SXshUoge9DmJaJGirqff7ZtJ/QZPfm/719rvAFxFILWHtAkB7gyuqZ/5nxN6Y9+451 jhjKZcfZKlfg/86yzBy+hCfVw9cvWverPuU//zTQ= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [95.163.41.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C9610BD3DF1 for ; Mon, 1 Jul 2024 12:33:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C9610BD3DF1 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1sODPr-00000008sbo-3FDD; Mon, 01 Jul 2024 12:33:44 +0300 Date: Mon, 1 Jul 2024 12:33:38 +0300 To: Maxim Kokryashkin Message-ID: References: <20240626083721.11596-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92EE09148F40C5446ED6AE8E79F10FAC94D3B9CDC3FEF69D0182A05F538085040FB532008235C8015C7A4B249DE6549FD3E83CDBD22A208CE595DACE50A8BD5332D7423A3730B9CE4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7484B509D84968742EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F10F1F3256FD32E28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D860D60EA533C179C901328E51308820FE2865FE6CB94FC07BCC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD183FC91FA280E0CE3D3A03B725D353964BD2DCF9CF1F528DBC35872C767BF85DA227C277FBC8AE2E8BEBEE3B39F980227375ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A54CE789ED8DCD88925002B1117B3ED69676125AAC2E6473F53E67C18142C611B7823CB91A9FED034534781492E4B8EEADA79578C5CF9A9009BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF9688EF90FE271976ED52202F13ECB122670885879A7B1F993533AC1B59AF21149B332213384B53539DF1169A732047E3C227EFCB9102435C39A00BB3CF7CAFBA4DFED9F3833F7D7D5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojn+1t2APtxW8bsNvoFBpA8A== X-DA7885C5: 2E625EEFF78DF0AAF255D290C0D534F9F762C0C6540C87940AAE7A2CA2EB103B007EFCD0870FDA835B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B2B54F70F72EDE57C867C21A773ACA770741DF4DD93122596E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Show name of NYI bytecode in -jv and -jdump. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comments and force-pushed the branch. On 01.07.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for two nits below. > > On Wed, Jun 26, 2024 at 11:37:21AM GMT, Sergey Kaplun wrote: > > From: Mike Pall > > > > Suggested by Sergey Kaplun. > > > > (cherry picked from commit d2fe2a6d465a3e4c74c9876db94ae606f9c6983b) > > > > This patch replaces the number of NYI bytecodes that can't be compiled > I guess `numeric value` is a bit better than `number`, but feel free to > ignore. Fixed, thanks! > > > with their names in the `jit.dump()` and -jv outputs. Since the > > functionality is the same, only `jit.dump()` is tested as most popular. > > > > Sergey Kaplun: > > * added the description and the test for the feature > > > > Part of tarantool/tarantool#9924 > > --- > > > > Branch: https://github.com/tarantool/luajit/tree/skaplun/lj-567-1176-print-nyi-names > > Related Issues: > > * https://github.com/tarantool/tarantool/issues/9924 > > * https://github.com/LuaJIT/LuaJIT/pull/567 > > * https://github.com/LuaJIT/LuaJIT/issues/1176 > > > > src/jit/dump.lua | 7 +- > > src/jit/v.lua | 9 +- > > src/lj_traceerr.h | 2 +- > > .../lj-567-1176-print-nyi-names.test.lua | 82 +++++++++++++++++++ > > 4 files changed, 96 insertions(+), 4 deletions(-) > > create mode 100644 test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua > > diff --git a/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua b/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua > > new file mode 100644 > > index 00000000..38829d2c > > --- /dev/null > > +++ b/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua > > + > > +jparse.start('t') > > +reset_jit() > > + > > +for _ = 1, 4 do > > + local _ = function() end > > +end > Maybe it would be better to create a separate function for FNEW too, > just for the uniformity, but that's not a big deal. Feel free to ignore. Fixed, see the iterative patch below: =================================================================== diff --git a/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua b/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua index 38829d2c..3d29c6bf 100644 --- a/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua +++ b/test/tarantool-tests/lj-567-1176-print-nyi-names.test.lua @@ -27,6 +27,12 @@ local function test_varg(...) for _ = 1, 4 do nop(...) end end +local function test_fnew() + for _ = 1, 4 do + local _ = function() end + end +end + local function test_uv() do -- luacheck: ignore @@ -56,9 +62,8 @@ test:like(reason, 'NYI: bytecode VARG', 'bytecode VARG name') jparse.start('t') reset_jit() -for _ = 1, 4 do - local _ = function() end -end +test_fnew() + _, aborted_traces = jparse.finish() assert(aborted_traces and aborted_traces[1], 'aborted trace with FNEW is persisted') =================================================================== > > > -- > > 2.45.1 > > -- Best regards, Sergey Kaplun