From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0905BE8E581; Mon, 17 Jun 2024 15:51:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0905BE8E581 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718628683; bh=af9r2YBqVr6IOQdLuPMyppIZTfvj4IjawPJLUwZ9sFA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vSuSOf2vVNAwE+yStPbsSE658xw5lkao2QGOWjWDU/8GRNax6P61LpVRc9sw+M2+L hYZIgikftIFNY/izv3A1sHf/c4kV01UdGfavOPtjF9YNYf9+QNn9H3NUPauSKNKcV6 zyleLwEcUjeiQZhknK8H1eVDIveTDeB7pOyYqGTI= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BCCD1E8E581 for ; Mon, 17 Jun 2024 15:51:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BCCD1E8E581 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1sJBpP-0000000Fqsx-42l2; Mon, 17 Jun 2024 15:51:20 +0300 Date: Mon, 17 Jun 2024 15:47:05 +0300 To: Sergey Bronnikov Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9A085BBEBA8705B83FEFFA82219864E2D3CCB56BE81F6F228182A05F5380850404C228DA9ACA6FE27C5C7610AE0AB05A3411046492FDDF8064B34A907AD68FDEBD7580E89494390DFA2698D7B1DC6BD28 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7818460412E3A2163EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063773AA33509B65BC498638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D865343816439E4CDE3325E9423A3F012AAA7483CE1BBA9878CC7F00164DA146DAFE8445B8C89999728AA50765F790063793270F7220657A0A389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC80839144E5BB460BAF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C093C2F12201C912A040F9FF01DFDA4A84AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3437A22C6F51CB4CBBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B64854413538E1713F75ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5EFBE14D36A0CA7325002B1117B3ED6963D62DB2471FF3626E99897350C7C491E823CB91A9FED034534781492E4B8EEAD887A4342A344B6EDBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFAFC8A527BDCE2203ABD8D8922AC737DE1F9972E9B3EF1F29F1912704266F219208FC8DA71D3854881521D91D49C923C72662AD92A3480D82B07B2CE03B717578F39C6CC38E8E1437C226CC413062362A913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSQgXCM0oo7UEgTVYuerRFg== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B599B8939FA188AE188411046492FDDF8064B34A907AD68FDEBB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] cmake: fix warnings about minimum required version X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! Generally LGTM, but I have a couple of questions: 1) What happens if we use a feature that is introduced in 2.4 (for example) and becomes deprecated in: a) 2.27? b) 2.30? 2) Can we declare the minimum required version in the root CMakeLists.txt of the project instead? On 21.03.24, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > CMake produces annoying warnings: > > CMake Deprecation Warning at src/CMakeLists.txt:7 (cmake_minimum_required): > Compatibility with CMake < 3.5 will be removed from a future version of > CMake. > > We cannot bump a minimum required CMake version without > bumping it in a Tarantool build system. However, we can set > a max supported CMake version and suppress a warning. > CMake 3.27.7 is a version used by me for a long time for > building LuaJIT. This version is tested and seen no policy warnings > with a that version. > --- > Branch: https://github.com/tarantool/luajit/tree/ligurio/fix-cmake-warnings > Doc: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html > > NOTE: another solution is using CMAKE_WARN_DEPRECATED, > but I don't like it. Let's discuss. > > 1. https://cmake.org/cmake/help/latest/variable/CMAKE_WARN_DEPRECATED.html > > CMakeLists.txt | 2 +- > etc/CMakeLists.txt | 2 +- > src/CMakeLists.txt | 2 +- > src/host/CMakeLists.txt | 2 +- > test/CMakeLists.txt | 2 +- > test/LuaJIT-tests/CMakeLists.txt | 2 +- > test/LuaJIT-tests/src/CMakeLists.txt | 2 +- > test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt | 2 +- > test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt | 2 +- > test/lua-Harness-tests/CMakeLists.txt | 2 +- > test/tarantool-tests/CMakeLists.txt | 2 +- > tools/CMakeLists.txt | 2 +- > 12 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 7f5e2afb..9edff6f3 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -8,7 +8,7 @@ > # --- Initial setup ------------------------------------------------------------ > > # See the rationale below (near LUAJIT_TEST_BINARY variable). > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > project(LuaJIT C) > > # XXX: Originally CMake machinery is introduced to make LuaJIT > diff --git a/etc/CMakeLists.txt b/etc/CMakeLists.txt > index d54fa794..39f6df77 100644 > --- a/etc/CMakeLists.txt > +++ b/etc/CMakeLists.txt > @@ -1,7 +1,7 @@ > # Building supplementary materials for LuaJIT. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > set(LUAJIT_PC_PREFIX ${CMAKE_INSTALL_PREFIX}) > if(CMAKE_LIBRARY_ARCHITECTURE) > diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt > index 03338306..be11dde6 100644 > --- a/src/CMakeLists.txt > +++ b/src/CMakeLists.txt > @@ -4,7 +4,7 @@ > # Copyright (C) 2015-2020 IPONWEB Ltd. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > enable_language(ASM) > > diff --git a/src/host/CMakeLists.txt b/src/host/CMakeLists.txt > index 1ce3e224..3ca158a5 100644 > --- a/src/host/CMakeLists.txt > +++ b/src/host/CMakeLists.txt > @@ -1,7 +1,7 @@ > # Building the toolchain for LuaJIT VM preprocessing. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > # FIXME: Both minilua and buildvm need to be build with the HOST_* > # toolchain. > diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt > index 3ad5d15f..8af043f7 100644 > --- a/test/CMakeLists.txt > +++ b/test/CMakeLists.txt > @@ -1,7 +1,7 @@ > # Running various test suites against LuaJIT. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > include(MakeLuaPath) > > diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt > index a0fb5440..a884070a 100644 > --- a/test/LuaJIT-tests/CMakeLists.txt > +++ b/test/LuaJIT-tests/CMakeLists.txt > @@ -1,5 +1,5 @@ > # See the rationale in the root CMakeLists.txt > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > add_subdirectory(src) > > diff --git a/test/LuaJIT-tests/src/CMakeLists.txt b/test/LuaJIT-tests/src/CMakeLists.txt > index 2f90da86..704c7acf 100644 > --- a/test/LuaJIT-tests/src/CMakeLists.txt > +++ b/test/LuaJIT-tests/src/CMakeLists.txt > @@ -1,5 +1,5 @@ > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > # Use `lib` prefix for loading via FFI and `require()`. > AddTestLib(libctest libctest.c) > diff --git a/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt b/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > index 98277f9a..7820d39b 100644 > --- a/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > +++ b/test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt > @@ -2,7 +2,7 @@ > # in scope of https://github.com/tarantool/tarantool/issues/5845. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > # XXX: There are two ways to set up the proper environment > # described in the suite's README: > diff --git a/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt b/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt > index b496cbab..d34151e1 100644 > --- a/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt > +++ b/test/PUC-Rio-Lua-5.1-tests/libs/CMakeLists.txt > @@ -2,7 +2,7 @@ > # in scope of https://github.com/tarantool/tarantool/issues/5845. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > # Build additional C libraries for tests. > AddTestLib(lib1 lib1.c) > diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt > index f748a8fd..2b4bb0ab 100644 > --- a/test/lua-Harness-tests/CMakeLists.txt > +++ b/test/lua-Harness-tests/CMakeLists.txt > @@ -2,7 +2,7 @@ > # in scope of https://github.com/tarantool/tarantool/issues/5844. > > # See the rationale in the root CMakeLists.txt > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > find_program(PROVE prove) > if(NOT PROVE) > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index e6d12984..c505f196 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -2,7 +2,7 @@ > # scope of https://github.com/tarantool/tarantool/issues/4478. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > find_program(PROVE prove) > if(NOT PROVE) > diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt > index 695c079a..09fe0230 100644 > --- a/tools/CMakeLists.txt > +++ b/tools/CMakeLists.txt > @@ -4,7 +4,7 @@ > # Copyright (C) 2015-2020 IPONWEB Ltd. > > # See the rationale in the root CMakeLists.txt. > -cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > +cmake_minimum_required(VERSION 3.1...3.27.7 FATAL_ERROR) > > set(LUAJIT_TOOLS_DEPS) > > -- > 2.34.1 > -- Best regards, Sergey Kaplun