From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 39C7FBA1AF5; Thu, 13 Jun 2024 13:40:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 39C7FBA1AF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718275212; bh=eJmdoOWgB5C2ZX1mtk+ri+aPm5Te3jUyNE+pbM/ootQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Po0s7bWhvyEXUftGKpCRoFV+PKi8C/Q+1oW1/0yr03ag320To1nqfS9urDPc8vZi2 vbVX5/MwuT92JGIzRwrn3LaHqm4iejTxLstCMGIpyfAfbKr5NVC/uJtt68OaR4kFW3 BEq4gdyiRXi5uNsO2CeB+wP1No0SHMoHxhR/TANE= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C362ABA1AED for ; Thu, 13 Jun 2024 13:40:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C362ABA1AED Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1sHhsH-00000002NYb-0TrM; Thu, 13 Jun 2024 13:40:09 +0300 Date: Thu, 13 Jun 2024 13:35:56 +0300 To: Sergey Bronnikov Message-ID: References: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> <136143ee-64e4-48e0-bea3-af066eea6030@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <136143ee-64e4-48e0-bea3-af066eea6030@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9AC8CA0B4439200FA28F1BD06D4CF66E6FBB893C35490C21C00894C459B0CD1B9608C245FF5E8015F28D5C4874F525AA3C7AB595D5D25A5F37B8B5E189A3AB1E708E1323863CD3BC3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7364F8074C6DFACE2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36A3ABB5079932767D3CE53ED023E099E320B8B72494B01590A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C327ED053E960B195E089D37D7C0E48F6C8AA50765F7900637427B078F297B269AEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A52AD18F07EBF794F15002B1117B3ED6966578EAFEE2EC35111BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7131E876AAF471F42404819F0ADF93FC41A20A15A51661EB779FE4C39ED75BE1696309706696DB6204A26A3878DC13303BB008D03B5CA4DBE137FF6D12815645E37CD76F57975DDC5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AlOgnFR7Qavbw== X-DA7885C5: 7C4C767DD77712AAF255D290C0D534F964145E962C9CD3089CE6BE2D7F1F82AC988A5A2335A4AC575B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B9C7B600C96F0477F90B09B7EEAEE955985F525E083865687E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Please consider my answers below. On 07.06.24, Sergey Bronnikov wrote: > Sergey, > > > thanks for the patch! See my comments below. > > Sergey > > On 15.05.2024 15:32, Sergey Kaplun wrote: > > Relates to tarantool/tarantool#8473 > > --- > > .github/workflows/sanitizers-testing.yml | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml > > index 154ebe40..4bf7d023 100644 > > --- a/.github/workflows/sanitizers-testing.yml > > +++ b/.github/workflows/sanitizers-testing.yml > > @@ -91,5 +92,8 @@ jobs: > > symbolize=1: \ > > unmap_shadow_on_exit=1: \ > > " > > + UBSAN_OPTIONS: " > > + print_stacktrace=1 \ > I propose to move these env variables to CMake. I suppose this is the same reason as for ASAN options: when run the asan + lsan CI in the tarantool repository, it configures its own ASAN + UBSAN options. To avoid their overwriting in our CMake file, we don't include this part there. > > + " > > run: cmake --build . --parallel --target LuaJIT-test > > working-directory: ${{ env.BUILDDIR }} -- Best regards, Sergey Kaplun