From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A285BBA1AC0; Thu, 13 Jun 2024 13:04:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A285BBA1AC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718273097; bh=vLE4/8x4yKIPwKOa0qSTBkPGLf1/jVwbWJMPTwIqPtw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ouFqWEKb/OvJR85fgPjDOAGHDgSM6pvs8P+uNeaFn2EMZvnOrEUQ7ZJdudgwoS6S7 IJRNAB4lnp2nP7GajntFrIR2b4cOksb3zDWiJodLffB8uOGOiyBLGCSJ2ixgxCcayD Dvr/XVXo4vfzPe26l0uk000DK8KdHnz4oDDJX/1w= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [95.163.41.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9AB4FBA1AC0 for ; Thu, 13 Jun 2024 13:04:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9AB4FBA1AC0 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1sHhKB-00000007BKe-2jKY; Thu, 13 Jun 2024 13:04:56 +0300 Date: Thu, 13 Jun 2024 13:00:43 +0300 To: Sergey Bronnikov Message-ID: References: <7c0a7be30070d085d6ddd3b56c4338686e1c2baa.1713773432.git.skaplun@tarantool.org> <42b64daf-a9f6-4267-9d22-4c8d7b88fdca@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42b64daf-a9f6-4267-9d22-4c8d7b88fdca@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9AC8CA0B4439200FAA6268B5D05BFD5F405B302337288676B00894C459B0CD1B95D025216D64869BF9BF30199346FE379B5EE767E42C82E805807D17EB30F7B310C43EDF95CA0F6DD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AC4684DF4EC4B256EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CDE631A26C8A2C128638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D822A3B0B38DF32E047CFFB34769A30E5580DC0099E2C6C4BFCC7F00164DA146DAFE8445B8C89999728AA50765F79006375FFD5C25497261569FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390D92131081DE748117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7FCEEFFE83360B3FE2DBA43225CD8A89FB26E97DCB74E6252262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A537961650CADC1DFC5002B1117B3ED696590A5F2810CD0AACCCE9A60C8CB01D7C823CB91A9FED034534781492E4B8EEAD4ECBDE8281F904F9BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCC2AEF307F62BB1E65F9CA5BBFB974555F0430FE9E46893666DB620F05EB269A498A0925D890345004A26A3878DC133036E4F45BD2637144E5998FEFDA3D78F74C50EB9025650E1F5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AkglcUA4qq3/w== X-DA7885C5: 043D7E432F6575D3F255D290C0D534F9971A709FA51E9B59036D526DAC16682FC3977ADC7A5BA9945B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B12060E6ACEDA808F4547AA19E568B1269610A1DA2BF17ACEE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1 3/5] test: allow `jit.parse` to return aborted traces X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! On 06.06.24, Sergey Bronnikov wrote: > Sergey, > > > thanks for the patch! Please see my comments below. > > On 22.04.2024 11:49, Sergey Kaplun wrote: > > Now information about the abort of the trace is saved in the > > `abort_reason` field of the corresponding structure. The > > `jit.parse.finish()` returns now the second table containing aborted > > traces. Each table key is a trace number containing an array of > > potentially traces with this number, which was aborted. > > > > Needed for tarantool/tarantool#9924 > > --- > > .../unit-jit-parse-abort.test.lua | 38 +++++++++++++++++++ > > test/tarantool-tests/utils/jit/parse.lua | 22 ++++++++--- > > 2 files changed, 55 insertions(+), 5 deletions(-) > > create mode 100644 test/tarantool-tests/unit-jit-parse-abort.test.lua > > > > diff --git a/test/tarantool-tests/unit-jit-parse-abort.test.lua b/test/tarantool-tests/unit-jit-parse-abort.test.lua > > new file mode 100644 > > index 00000000..91af5a56 > > --- /dev/null > > +++ b/test/tarantool-tests/unit-jit-parse-abort.test.lua > > @@ -0,0 +1,38 @@ > > +local tap = require('tap') > > +local test = tap.test('unit-jit-parse'):skipcond({ > > Usually a name passed to `tap.test` matches to test file name, > > but here it is not matched. My bad, thanks! Fixed, see the iterative patch below. =================================================================== diff --git a/test/tarantool-tests/unit-jit-parse-abort.test.lua b/test/tarantool-tests/unit-jit-parse-abort.test.lua index 91af5a56..f09e696c 100644 --- a/test/tarantool-tests/unit-jit-parse-abort.test.lua +++ b/test/tarantool-tests/unit-jit-parse-abort.test.lua @@ -1,5 +1,5 @@ local tap = require('tap') -local test = tap.test('unit-jit-parse'):skipcond({ +local test = tap.test('unit-jit-parse-abort'):skipcond({ ['Test requires JIT enabled'] = not jit.status(), ['Disabled on *BSD due to #4819'] = jit.os == 'BSD', }) =================================================================== > > > + ['Test requires JIT enabled'] = not jit.status(), > > + ['Disabled on *BSD due to #4819'] = jit.os == 'BSD', > > +}) > > + > > +local jparse = require('utils').jit.parse > > + > > +-- XXX: Avoid other traces compilation due to hotcount collisions > > +-- for predictable results. > > +jit.off() > > +jit.flush() > > + > > +test:plan(1) > > + > > +jit.on() > > +-- We only need the abort reason in the test. > > +jparse.start('t') > > I would add a comment with explanation what does 't' flag mean. > > Feel free to ignore. I suppose that readers who use `jit.dump` from time to time already know all flags. If not, it can be easily found in . > > > + > > -- Turn off compilation for the module to avoid side effects. -- Best regards, Sergey Kaplun