From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2F9E1B5B9AF; Thu, 13 Jun 2024 10:38:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F9E1B5B9AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718264316; bh=7XD6BHCzg99sSlPiK3ASps17+lI/OQHWkubo3nDjuRM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tFhSdUJ7bqcAVnN7d+NBnRbT/rwbXbLLru/KFaKCBZIyHWDl68WGKVdaAX4IgkzLs 7UFZ/BN59LIJ+OniWRshr9y7A3oa/fViC8Lcu5TyJOm7s+3EqakJ3r9F3+X4LNuvtB Ml+Lq/VY/pyX59BSTHa7gPJi8DSmqMcox/rk+xU0= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D3521B5B9A4 for ; Thu, 13 Jun 2024 10:38:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D3521B5B9A4 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1sHf2X-00000006220-3Xcl; Thu, 13 Jun 2024 10:38:34 +0300 Date: Thu, 13 Jun 2024 10:34:21 +0300 To: Sergey Bronnikov Message-ID: References: <034b0afe429e672809ec8192ff1fb41a7bfd2937.1717424008.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9AC8CA0B4439200FAC9ED020CEABC603EBFE2E3CBD10956AC00894C459B0CD1B90E9CAB54BEEA71F8608635B212260D365E541F88CBC1A9A010BE2026731AB90496BFE15B8ADB4371 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374C1E21D5B12C874B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D801C6F3C405951E0BB1FA52F7E045103C087A5EDF59675A12CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F7900637F09814068C508CC822CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A58747B1D64962D6A35002B1117B3ED6962824278A5F95FF87D57BAD45EC4C5DE1823CB91A9FED034534781492E4B8EEAD003C2D46C52F18F2BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F1257DC9690AEBA1C03A967DA494F36D20E3C7D829B2BE38068AC2EAAC8936A6783CD13281D09BBB1D7E09C32AA3244CA64DA7FC19BC059CA0CBE312C330D7D5DCBA0ACB643AED05EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojP/c/PTD82AlNXuQPqQGXLA== X-DA7885C5: 8474AB16616CDEFAF255D290C0D534F9BE236D9813ECFF544AA17F7B0CBA418336AC695F5C11CEDA5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BBA264C5AF551B0679524E574C5FDBA8CAB94F54C37958935E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/4] FFI: Allow ffi.metatype() for typedefs with attributes. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 11.06.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM with a nit below. > > On 03.06.2024 17:34, Sergey Kaplun wrote: > > From: Mike Pall > > > > Reported by Eric Gouyer. > > > > (cherry picked from commit 27a6fee82e91319bbed8c3aa443aa2b0f1b0a470) > > > > Before the patch, `ffi.metatype()` raises an error when calling it on > > ctype with attributes. This patch fixes the behaviour by using > extra whitespace above > > `ctype_raw()` instead of `ctype_get()` to follow child ctypes unless > > there are no attributes on the ctype. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#9924 > > --- -- Best regards, Sergey Kaplun