From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5D2A2CCC214; Mon, 10 Jun 2024 12:45:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5D2A2CCC214 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1718012721; bh=C3BYs1ix02I6z82zyBWvh4ODghxGHnRonaPrS0SWQ94=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ODpYd4PdvNlcsMeQMZ+OEYSm/L6h+1mTasHNwlWZnthSRR+0Y637mGdFcCZ3Sun93 RA7YYB1wlmZ6cLTu4U/Hgi6LXRP+GcpuXZLXhZd5krWnVYPB7L8v7vb8SJRps10zL0 BmCm2l6HH5LdJCX+XSduHxSJRsqDDikcG09Nc6Dc= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [95.163.41.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 70CAA5BA3BD for ; Mon, 10 Jun 2024 12:45:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 70CAA5BA3BD Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1sGbaY-0000000DiUI-0qGG; Mon, 10 Jun 2024 12:45:18 +0300 Date: Mon, 10 Jun 2024 12:41:05 +0300 To: Sergey Bronnikov Message-ID: References: <88eab16fca9056a057df5506a0af637c8d4a0ffd.1717682341.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88eab16fca9056a057df5506a0af637c8d4a0ffd.1717682341.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93F90B0A9EAEE607A713C8B68ED798B1B063E082AE583AA2600894C459B0CD1B9321C7717BCAB6194721BE3D92DD388D36B424881D97146CAA3FBE81311046F36AB5D286C5C76880D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375F0BD5CF353A411D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8FED35E278AA724946B2429F3C2B392D6577EFA02C11520D3CC7F00164DA146DAFE8445B8C89999728AA50765F7900637BA939FD1B3BAB99B389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88C0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3D8561A2FEC730ACEBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6957A4DEDD2346B4275ECD9A6C639B01B78DA827A17800CE76D0F27F7E6A6C418731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58E64B356149F4DDC5002B1117B3ED696DC53F1C562E976CD219207EC0A953D2C823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742DC8270968E61249B1004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34AAC3D1FDB34D04882160BA95219746F9019AA0FE563877B4B138568C19805E3AECED05BE362838291D7E09C32AA3244C93EC844288010591459F46583F07963C644B8919947955A7EA455F16B58544A21C197AAF4D2E4732A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwrGBHWBGYd8Vr0EvfspLAw== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59E356BEDCD6AF80C4AC8EDD30083ED68E8EA4A5DCCDD54940B7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: remove inline suppressions of _TARANTOOL X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, after fixing my comment below. On 06.06.24, Sergey Bronnikov wrote: > From: Sergey Bronnikov > > The patch defines _TARANTOOL as a global in luacheck configuration > file and removes inline suppressions in test files. > --- > Branch: https://github.com/tarantool/luajit/tree/ligurio/fix-_TARANTOOL > > 12 files changed, 1 insertion(+), 12 deletions(-) > > diff --git a/.luacheckrc b/.luacheckrc > index a32012ca..62ceeaa2 100644 > --- a/.luacheckrc > +++ b/.luacheckrc > @@ -1,7 +1,7 @@ > -- Use the default LuaJIT globals. > std = 'luajit' > -- This fork also introduces a new global for misc API namespace. > -read_globals = { 'misc' } > +read_globals = { 'misc', '_TARANTOOL' } Can we use it only for directory to avoid it appearing in the Lua sources inside the repository? =================================================================== diff --git a/.luacheckrc b/.luacheckrc index a32012ca..7b5634a5 100644 --- a/.luacheckrc +++ b/.luacheckrc @@ -3,6 +3,10 @@ std = 'luajit' -- This fork also introduces a new global for misc API namespace. read_globals = { 'misc' } +-- The `_TARANTOOL` global is often used for skip condition +-- checks. +files['test/tarantool-tests/'] = {read_globals = {'_TARANTOOL'}} + -- These files are inherited from the vanilla LuaJIT or different -- test suites and need to be coherent with the upstream. exclude_files = { =================================================================== > > -- These files are inherited from the vanilla LuaJIT or different > -- test suites and need to be coherent with the upstream. > -- > 2.34.1 > -- Best regards, Sergey Kaplun