From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7EB37B9D401; Mon, 27 May 2024 15:34:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7EB37B9D401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1716813290; bh=Mc3Tc5YToucMbPCh98Q9J3crGsKMZ9SLXCsUpshdzjs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oMPM0M2cWLOu4geEbufPm4rZOQgcVdcGNoU8H6Um3Q1iLCYy31Zc6KdGhMJTAywAh plcVcJ5ZolPGqtYcaCCQS/eJ6m02Wjq26vc2XqXRUuDZ2Tmui01KzIwAeDphX6+cwa VQkR+kEa3pf+xCwtf4oV5fGKb1sMNPIk9VFgyDk4= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2F987B868D1 for ; Mon, 27 May 2024 15:34:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F987B868D1 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1sBZYu-0000000AVSo-1o9q; Mon, 27 May 2024 15:34:48 +0300 Date: Mon, 27 May 2024 15:30:35 +0300 To: Maxim Kokryashkin Message-ID: References: <8d8b6798b2a52f868c7b6b6d1c56d07ae8d20fdd.1715776117.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD99EF2330544E8CB05AEA28CB29004E22D1454D3C93E64AC31182A05F538085040F16FF8B2E6AA0D24C591814E25D11F9F1A51D3353C3F96AB0029590C762AD436AE609E793340973E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74D0D2DEF2EB846B0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376F978168E59B07A5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36F6FC9CE124629DB36E3F7256EA255499BA1773FABF5D8207A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF8A6EFC3CE370B017BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6E1D16C38C1488AB776E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249D082881546D93491E827F84554CEF50127C277FBC8AE2E8B2EE5AD8F952D28FBAAAE862A0553A39223F8577A6DFFEA7CB1724D34C644744043847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5C177FAC04C7773045002B1117B3ED696556300F1AA48E44C47A99E6294EE8661823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349A401E2B4D763A4A2D04D88212D7CBE68FBB6E97CBB1FFC007F8547D91B5E4D93506833B8947C2DF1D7E09C32AA3244C33B8E487C1BF4BF3EBBA027F22CEDE66BBC3C7826B432E4AEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj0imwrCqrDNCt+J/rUbfR+g== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59161D2B9879DD94FBC591814E25D11F9F1A51D3353C3F96ABB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] ci: enable UBSan for sanitizers testing workflow X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! See my answers below! On 26.05.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single nit below. > > On Wed, May 15, 2024 at 03:32:01PM UTC, Sergey Kaplun wrote: > > Relates to tarantool/tarantool#8473 > > --- > > @@ -70,9 +70,10 @@ jobs: > > cmake -S . -B ${{ env.BUILDDIR }} > > -G Ninja > > ${{ matrix.CMAKEFLAGS }} > > + -DLUAJIT_ENABLE_GC64=ON > I see why this change was made, but it is irrelevant to the patch. > The decision to leave it as it is or remove is up to you. Added the following paragraph to the commit message to avoid confusion: | Also, this patch sorts the corresponding flags in the CI workflow | alphabetically for better readability. > > -DLUAJIT_USE_ASAN=ON -- Best regards, Sergey Kaplun