From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7C2CEA18883; Mon, 13 May 2024 15:28:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7C2CEA18883 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1715603336; bh=rRA+PQG0W9R1A3TUHhyLgrFHR+8jRTOBEA86NBCB1W0=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bSRNjtuS7lBwfhzdqb44zZKC8kFa7wvsPBHfgk+GPhZi3pmQxNAg6OPTCUQcviNeP cwagM0zMusUBRD9Bv+XxlYnAl15nT5qb5f+7vuuz29O578Z6vEfUFELcv6UudBy9/z 3u6b6VRSjNq6B4xaFTEC7UJrw6y/iDzWdNfDK6F4= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [95.163.41.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 93CD9A18883 for ; Mon, 13 May 2024 15:28:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 93CD9A18883 Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1s6UnW-00000005w1F-03yG; Mon, 13 May 2024 15:28:54 +0300 Date: Mon, 13 May 2024 15:24:42 +0300 To: Maxim Kokryashkin Message-ID: References: <20240424103720.9464-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90CF8E60E6BB262B7D7A62B5C1895F11E96289A11FBA98B18182A05F53808504084902D24D77C7E11D27678DDAA806314EF303472E5491425BFE9B061F184F9E536A877216E458963 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76D34FAA3D8B31588C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7EFCED9770EA041F4EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F3670B721F55056B40800D7FDAB829B95C6ADEAECB1E8961BAEA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C317B107DEF921CE79089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5D3427D9CE3D79DF55002B1117B3ED696EC10924CD8F0B450219207EC0A953D2C823CB91A9FED034534781492E4B8EEAD9DB614F8F96CFA30BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF67E372E24FBBC87F013066627823110E9B0E18E82D63D101FF0CDDAC1164B0EDEC58EB6354A2D53AA198138DB11F6B95B2C6AA91F71E70606E8525CBBD5D9867071420DD0E8B30535F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojcheZ1TQj/ofKecxB30tWAQ== X-DA7885C5: 39E31977B0DB635BF255D290C0D534F9D7C06C1062F547B4C835BA89FB3321C6226406D2FA2B04CD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9BD4435AA7F6A7F72D171F482FD539BF8441F0F0B482FE9FA7E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Check for IR_HREF vs. IR_HREFK aliasing in non-nil store check. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review. Fixed your comments and force-pushed the branch. On 05.05.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for two nits below. > On Wed, Apr 24, 2024 at 01:37:20PM UTC, Sergey Kaplun wrote: > > From: Mike Pall > > > > + > > +-- Amount of iteration to compile and execute the trace. > Typo: s/iteration/iterations/ Fixed, thanks! > > +local LOOP_LIMIT = 4 > > + > > + -- with the corresponding snapshot is skipped. > > + -- The difference in the emitted IR before and afterthe patch > Typo: s/afterthe/after the/ Fixed, thanks! See the iterative patch below. =================================================================== diff --git a/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua b/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua index 6b72c97a..882ca780 100644 --- a/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua +++ b/test/tarantool-tests/lj-1133-fwd-href-hrefk-alias.test.lua @@ -15,7 +15,7 @@ local rawset = rawset -- field in HREFK IR. local HASH_NODES = 65535 --- Amount of iteration to compile and execute the trace. +-- Amount of iterations to compile and execute the trace. local LOOP_LIMIT = 4 -- Function to be called twice to emit the trace and take the side @@ -42,7 +42,7 @@ local function trace_aliased_tables(t1, t2) -- `lj_opt_fwd_wasnonnil()` missed the check that HREFK and -- HREF may alias before the patch, so the guarded HLOAD IR -- with the corresponding snapshot is skipped. - -- The difference in the emitted IR before and afterthe patch + -- The difference in the emitted IR before and after the patch -- is the following: -- | 0004 > tab SLOAD #1 T -- | ... =================================================================== > > + -- is the following: -- Best regards, Sergey Kaplun