From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4F35AB006D1; Mon, 13 May 2024 14:54:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4F35AB006D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1715601247; bh=Jl5+/UxkpIWROc7+VXB2nihn3WQsGgECbh3Jgc/+ROw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YH/kJhgWF38gsYGC2TWT1nOPReIPnVVOKU1GFLGNEimyGoesVtYoNR+VcLCXyuWl4 3irgJhiMb3zdWljflykHZyHKavaW8qzoyHvN5eS0K2yWGBcdZ/t5vlloGceMH/fqkK PzsZl41EtdYnHSkUadY0k954u95CS85527+tOXVc= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 76019B006D2 for ; Mon, 13 May 2024 14:54:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 76019B006D2 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1s6UFp-000000085J3-0HLZ; Mon, 13 May 2024 14:54:05 +0300 Date: Mon, 13 May 2024 14:49:53 +0300 To: Maxim Kokryashkin Message-ID: References: <400b3ae2c1454663c6d975b55a68db2621132cc1.1713773432.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD90CF8E60E6BB262B7D7A62B5C1895F11E96289A11FBA98B18182A05F53808504010C9F19F48A5D0DFC7A4B249DE6549FDD95F94309E77D34A1C32CF11B01418A43DE74FFC206C9863 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE795530B80AF2ADB7BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063781E06E36B00F36668638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DA12F7E5D56835526D1234B3361AC0483CCF0A0D46FED286CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B2FFDA4F57982C5F435872C767BF85DA227C277FBC8AE2E8B08F9A42B2210255C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A590832357CCA73AC15002B1117B3ED696F6967472FAFB6B005D145BB8EF0DE66B823CB91A9FED034534781492E4B8EEAD5E90D3DD2A5B7EAFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34E20F2278F74481A1A0676D7B5D1CCCC562F29399977E986B37C7CB00CEE9631B4A4DB39EA6FFB51E1D7E09C32AA3244CA70E7A805AA124933BA3F8B02A6D222B724F200165E97C7CEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojcheZ1TQj/odSNvE/fFkNrQ== X-DA7885C5: 2383C54FBB6CEFA3F255D290C0D534F95B9EAD7B27A1BA98951A771E53682E33DA8D94A5E5E2F5FD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393C6D0B12EA33CAA9B5F6D29C9C610825D1AD34C80A30CE8DC78A43410C4A7F05EE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v1 2/5] ci: add tablebump flavor for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment. See the iterative patch below. On 05.05.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for the single nit below. > On Mon, Apr 22, 2024 at 11:49:55AM UTC, Sergey Kaplun wrote: > > This flavor enables the LUAJIT_ENABLE_TABLE_BUMP option to test table > > bump optimization. > > > > Needed for tarantool/tarantool#9924 > > --- > > # DUALNUM is default for ARM64, no need for additional testing. > > - FLAVOR: dualnum > > ARCH: ARM64 > > + # Within table bump optimization enabled (and due to our modification > Typo: s/Within/With/ Fixed. > > + # related to metrics), some offsets in GG_State stop fit in 12bit > > + # immediate. Hence, the build failed due to the DASM error > > + # (DASM_S_RANGE_I). > > + - FLAVOR: tablebump > > + ARCH: ARM64 =================================================================== diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml index 6ce100f4..70096439 100644 --- a/.github/workflows/exotic-builds-testing.yml +++ b/.github/workflows/exotic-builds-testing.yml @@ -58,10 +58,10 @@ jobs: # DUALNUM is default for ARM64, no need for additional testing. - FLAVOR: dualnum ARCH: ARM64 - # Within table bump optimization enabled (and due to our modification - # related to metrics), some offsets in GG_State stop fit in 12bit + # With table bump optimization enabled (and due to our modification + # related to metrics), some offsets in GG_State stop fitting in 12bit # immediate. Hence, the build failed due to the DASM error - # (DASM_S_RANGE_I). + # (`DASM_S_RANGE_I`). - FLAVOR: tablebump ARCH: ARM64 runs-on: [self-hosted, regular, Linux, '${{ matrix.ARCH }}'] =================================================================== -- Best regards, Sergey Kaplun