Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Correct fix for stack check when recording BC_VARG.
Date: Fri, 12 Apr 2024 14:39:20 +0300	[thread overview]
Message-ID: <ZhkdaO1juodZQLYw@root> (raw)
In-Reply-To: <34beef1f-9342-4073-b44c-b34e862dfad7@tarantool.org>

Hi, Sergey!
Thanks for the review!
Fixed your comment and rebased the branch to the current master.
Also, fixed the ticket number to part 8.

On 12.04.24, Sergey Bronnikov wrote:
> Hi, Sergey
> 
> 
> thanks for the patch! LGTM wit h a minor comment.
> 
> 
> 
> On 04.04.2024 19:14, Sergey Kaplun wrote:
> > From: Mike Pall <mike>
> >
> > Reported by Yichun Zhang.
> >
> > (cherry picked from commit b2791179ef96d652d00d78d2a8780af690537f6a)
> >
> > This patch is a follow-up for the commit
> 'for' -> 'to'

Fixed, thanks!

> > 5f0a43ace8cfe98c3e8cd313bf809b4405ba395d ("bugfix: fixed assertion

<snipped>

-- 
Best regards,
Sergey Kaplun

      reply	other threads:[~2024-04-12 11:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 16:14 Sergey Kaplun via Tarantool-patches
2024-04-09 11:00 ` Maxim Kokryashkin via Tarantool-patches
2024-04-12 11:35 ` Sergey Bronnikov via Tarantool-patches
2024-04-12 11:39   ` Sergey Kaplun via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhkdaO1juodZQLYw@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] Correct fix for stack check when recording BC_VARG.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox