From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 613CEB41B9A; Fri, 12 Apr 2024 14:31:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 613CEB41B9A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1712921510; bh=Rr7PQMzVZ4XBPS5zw9txzJixpjlB0J/A45OBkanr0mc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UCU7THvrRF4BfEj+iYgFWhNYBbbGI8fGxLX/EF3Fyb8s35kXxKnw2HZF8IUap9nHY QDJBPobkC06oTwc8tK1fCmuKBuctp90fVU0l6+fXMX/neMahFuWxUcv2sjMCdFjpG3 de33AhTdCc63zKgTpfPPf+ehbMLgB+844pzxskJk= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 85775B41B99 for ; Fri, 12 Apr 2024 14:31:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 85775B41B99 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1rvF8G-00000008iZV-1Ehi; Fri, 12 Apr 2024 14:31:48 +0300 Date: Fri, 12 Apr 2024 14:27:46 +0300 To: Sergey Bronnikov Message-ID: References: <0968f450b5ddf3a14ef9ef865bafad99a5e626b4.1712841312.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0968f450b5ddf3a14ef9ef865bafad99a5e626b4.1712841312.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D327C87852EB66D3FD55D334CC1A2A9DF13713DBDDE85F9F182A05F538085040BE5235E022B3038BC7A4B249DE6549FDEFA2A6B76E21FD3E6B69C249257E1AB1EEE848E17894A636 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBCED7D376B82B5EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FA81DCE0280C9CC68F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566F8F0F87BD35B7CDBE16B95BB19BCBF8709A1052FBE859EC5522A96D09F86B739389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CE9959E2676FD87735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5C1CDB2F4450590EA5002B1117B3ED69628DD71EF317FA85CB2920F75BA9A967F823CB91A9FED034534781492E4B8EEAD5DF1C2DF01CE7211BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D341776B9FDE05FBA7ACF5520417F7FAB121C3862D01F62DA704A246621AFD4340F7B716EB01620ED9E1D7E09C32AA3244CD64C3153E8F3B5A83BA3F8B02A6D222B3CAD2E1A388FAD4DEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59829709634694AABAED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojj8Sl06kWf00vEROLV45qSA== X-DA7885C5: 13DC07504D0AF86BF255D290C0D534F9CA90E11986BDE74E514178CCD88F332EEADAB8356469B53D5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE331BEBA665F8AEE186941E33AA59678B3545D717D4D1EB429AE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/4][v2] OSX/iOS/ARM64: Fix bytecode embedding in Mach-O object file. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the fixes! LGTM, with a several minor nits below. On 11.04.24, Sergey Bronnikov wrote: > From: Mike Pall > > Thanks to Carlo Cabrera. > > (cherry picked from commit b98b37231bd2dcb79e10b0f974cefd91eb0d7b3a) > > Mach-O FAT object files generated by LuaJIT for ARM64 Had Typo: s/Had/had/ > an incorrect format due to the usage of the 32-bit version of > FFI structure. This patch adds the 64-bit structure definition Typo: s/FFI structure/the FFI structure/ > and uses it for ARM64. > > Sergey Bronnikov: > * added the description and the test for the problem > > Part of tarantool/tarantool#9595 > --- > src/jit/bcsave.lua | 14 ++++- > ...-865-cross-generation-mach-o-file.test.lua | 55 +++++++++++++++++-- > 2 files changed, 63 insertions(+), 6 deletions(-) > > > -- Mach-O FAT object header. > @@ -221,9 +263,11 @@ end > -- > local SUM_CPUTYPE = { > arm = 7 + 12, > + arm64 = 0x01000007 + 0x0100000c, Minor: The comment will be appreciated: | x64 + arm64. > } > local SUM_CPUSUBTYPE = { > arm = 3 + 9, > + arm64 = 3 + 0, Minor: The comment will be appreciated: | x64 + arm64. > } > > -- The function builds Mach-O FAT object file and retrieves > -- > 2.34.1 > -- Best regards, Sergey Kaplun