From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 21A77A4BECF; Mon, 8 Apr 2024 18:20:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 21A77A4BECF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1712589649; bh=Hb2mmQHH4nAcodmokqy6DtAMe4ZKAXPeHdCLKRUdo/U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MkA8gylhW5wRIpiWGfIyodyfWKC4Imgo279jSSvuDPd4XCYfa/ndxvBJ63JYYq6i4 BxHHaLS0ulf2VYHm7U8VIPN+hqdYw8cFklUjSP9t9Ygi7BBNCED3/XnpqYLzOUDkz9 auE6tSG27bqRSr3AAotyX4MNAVN7+rb4/+7N7qvY= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 84BF4A4BEC0 for ; Mon, 8 Apr 2024 18:20:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 84BF4A4BEC0 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1rtqnd-0000000AZVY-1PwM; Mon, 08 Apr 2024 18:20:45 +0300 Date: Mon, 8 Apr 2024 18:16:44 +0300 To: Sergey Bronnikov Message-ID: References: <1fe5f0ebbd285bd58849be28548bcc8c8c68c2a1.1710416150.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1fe5f0ebbd285bd58849be28548bcc8c8c68c2a1.1710416150.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D327C87852EB66D3B7195700B3B2E938A71357BE968F1810182A05F5380850409822A0C8E5B836B3C591814E25D11F9F8B19593BD856B9BAF5BE69892C5964BCD90586D79C798AC7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AD2F2D6F6013FF7FC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7F12ABE79F2AB44EAEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD8718A46E958F2928FBAB90350D2FE45808F1201AC0C7E72A7A6A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3ED8438A78DFE0A9E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFFB892369DDD87097BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6378990534548B4FE76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249D082881546D93491E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B60A62CEF541B197C8089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5D71F36461540E0715002B1117B3ED69670C28290F222A1891BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEADB73CFAAED92B6E13BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA90FBDB21D1048045C735465B15289F8CB1B771986F98DD189CCC6E67DBC8D92F2D331BABA2AF9051CFDFDFCAF5E4A4B22A3572D2D435A90FEF9D275906E687FA1E6AAA558798B7FC226CC413062362A913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojabKNeIbMV3uctIk4twIvDw== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B595712A82051BB1471C591814E25D11F9F8B19593BD856B9BAB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS/ARM64: Fix bytecode embedding in Mach-O object file. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! The version on branch LGTM, except a single nit regarding the commit message below. On 14.03.24, Sergey Bronnikov wrote: > From: sergeyb@tarantool.org > > Thanks to Carlo Cabrera. > > (cherry picked from commit b98b37231bd2dcb79e10b0f974cefd91eb0d7b3a) > > Mach-O FAR object files generated by LuaJIT for arm64 had an incorrect Typo: s/FAR/FAT/ > format because FFI structure used for generation was wrong: > `mach_fat_obj` instead of `mach_fat_obj_64`. I suggest reformulating this as the following: | Mach-O FAT object files generated by LuaJIT for arm64 had an incorrect | format due to the usage of the 32-bit version of FFI structure. | This patch adds the 64-bit structure definition and uses it for arm64. > > Sergey Bronnikov: > * added the description and a test for the problem > > Part of tarantool/tarantool#9595 > --- > src/jit/bcsave.lua | 14 +++++++++++++- > ...-fix_generation_of_mach-o_object_files.test.lua | 4 +++- > 2 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/src/jit/bcsave.lua b/src/jit/bcsave.lua > index 7aec1555..069cf1a3 100644 > --- a/src/jit/bcsave.lua > +++ b/src/jit/bcsave.lua > diff --git a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > index 0519e134..0a11f163 100644 > --- a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > +++ b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > -- > 2.34.1 > -- Best regards, Sergey Kaplun