From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5033EA65F68; Tue, 26 Mar 2024 13:12:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5033EA65F68 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711447962; bh=5lM3ksr1MMf/Vp0QZhnWlyNsNyjm8ZwNZHiLHpjXgnw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bUQz8Gd72qdTYESe4pwnUVttjbTHJvph9xfuKBxlwDRJQF74bjcwebepTWvGbwadC H2gFu2bqqzNsVr3TOJzZzhFppE1gfUPBXgRox2sill+GQzuWWMpTQhjPw/Vkv9Ds/x /Lj9tS/hkLKSTTKz6++NB8wycSZODG7Stz9OXzZQ= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 75C62A65F60 for ; Tue, 26 Mar 2024 13:12:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 75C62A65F60 Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1rp3nL-0000000E6yj-1uo3; Tue, 26 Mar 2024 13:12:40 +0300 Date: Tue, 26 Mar 2024 13:08:41 +0300 To: Sergey Bronnikov Message-ID: References: <19e2e200fa5da4d6fb6875e599b9f8bd0a0048b9.1711441864.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19e2e200fa5da4d6fb6875e599b9f8bd0a0048b9.1711441864.git.sergeyb@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92CB91DAA594FB6BF71C75EE959EE1452FAD1029ACF3A1BB1182A05F53808504057324546EF9A359103ED270C30F246C5AAA04D736188162E4754DF44A5C4454ADE81258B7D5E2227 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AF18881564A951B9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637329F9579A0E72DCC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85F7EF55EBA5AFAA4652B6A6C0EC0E695F7CAB201C083EB9BCC7F00164DA146DAFE8445B8C89999728AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8D2DCF9CF1F528DBCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88AD7EC71F1DB884274AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3F4C2C1D91A3D1C5BBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30A3B31C63366F72535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5E072C56451D5BBF15002B1117B3ED696C2470541E3998C6303803A57F48E4E5A823CB91A9FED034534781492E4B8EEAD09122B91796FF21FBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFEF0BF679FFDF1EFC5DF0C30B5CACDE2361084709ECE8461CF31489BEE6952090519D809D4148B496F212F37558E72466C76D5DFD5579137921A1F50B01305CE4326A22F0B19D7DD5C226CC413062362A913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhu0AwaaKnHqcWf5wAwosKA== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B598FA8864D2419EEF603ED270C30F246C5AAA04D736188162EB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/6] test: fix lj-802-panic-at-mcode-protfail GCC+ASan X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the patch! LGTM, except 2 typos regarding the commit message and the comment. On 26.03.24, Sergey Bronnikov wrote: > From: Sergey Kaplun > > The aforementioned test uses `LD_PRELOAD` to mock the system call to > `mprotect()`. The GCC implementation of libasan requires that the ASan > library go first in the `LD_PRELOAD` list. This patch tweaks the > behaviour to avoid failure of the test. OTOH, this patch intorduces Typo: s/intorduces/introduces/ > warnings related to the libc leaks for a couple of tests, but they are > not treated as test failures. This should be fixed by target setting > LD_PRELOAD only for necessary tests when we start using CTest instead of > `prove`. > > Part of tarantool/tarantool#9656 > > Co-authored-by: Sergey Bronnikov > --- > test/tarantool-tests/CMakeLists.txt | 15 +++++++++++++++ > test/tarantool-tests/utils/exec.lua | 14 ++++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt > index e6d12984..35bcc5ef 100644 > --- a/test/tarantool-tests/CMakeLists.txt > +++ b/test/tarantool-tests/CMakeLists.txt > @@ -110,6 +110,21 @@ else() > list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) > endif() > > +# Some tests use `LD_PRELOAD` to mock system calls (like > +# overwrites > +# `mprotect()`. When compiling with ASan support under GCC, it is > +# required that the ASan library go first in the `LD_PRELOAD` > +# list. Set it manually, test will append it to the executed Typo: s/manually, test/manually. The test/ > +# process. > +# See also: https://github.com/tarantool/tarantool/issues/9656. > -- > 2.34.1 > -- Best regards, Sergey Kaplun