From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1FD329E4FBE; Wed, 13 Mar 2024 10:22:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1FD329E4FBE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1710314525; bh=KbVcH5qOeUpk3a91TYe0Jk+Dp8Mf7AOkgjs6fPx3bGA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Bv6Xo7ESlACFVom9tbZ/DMgiI9rh4efFf2euJX8T9pnMfFOx0CQHsJBbE6iaggjvb /sb+aTSLYJFqkc9HISEGF2RakKZgTRnlKs+jQqnR9ya6apY5wDtKoAi1sItcwCqHWo mTPJ+TjnS7pCKtT2h1/OmQ3XFFUX7L1CbD9uaCRA= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [95.163.41.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 97A1E40F5C3 for ; Wed, 13 Mar 2024 10:22:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 97A1E40F5C3 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1rkIw5-00000002QSP-2xHM; Wed, 13 Mar 2024 10:22:02 +0300 Date: Wed, 13 Mar 2024 10:18:02 +0300 To: Maksim Kokryashkin Message-ID: References: <20240311200455.25451-1-max.kokryashkin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311200455.25451-1-max.kokryashkin@gmail.com> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597D173D0CE202DA28435F3B31DD656B8ACF182A05F538085040A8F7BE4BDE01AA57F378A8CA21F699D62A0C9ED64E8682CE116A881B4A4449EED428EE335AABE4C5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75AD53DF1D86BACA3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063737452AF4BFD067BF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88A791DEDCECA9DBDD1737A9A688D726207D75A4FC4FE0A8ACC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8062BEEFFB5F8EA3EF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF8BD4E506CFA3D88C0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3D8561A2FEC730ACEBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3BE90F13D913F449135872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A54A149BFA6D11B03A5002B1117B3ED696537A9FBF32E541FD1BDDAE3D1EA49BEA823CB91A9FED034534781492E4B8EEAD0942DC5495D0595EBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF2B0049664A4CBEE693337BEBFAC635599CAE9BBAD09689849C50D60F7EEC45A03D7E4ABC8EFFEBBE7C77D8D956826D33D399907841D4F9992C335BF1EAD9C525990BFFC4E4D0D539C226CC413062362A913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtv/CB9kl0S3mg8b2ualuRg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76916FB1A1ABDEE8A55F378A8CA21F699D62A0C9ED64E8682CEB7CBEF92542CD7C88B0A2698F12F5C9EC77752E0C033A69E86920BD37369036789A8C6A0E60D2BB63A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v5] ci: extend tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max! Patch LGTM, except a few nits regarding the commit message and comments. Also, may you please provide two separate patches regarding backporting to the tarantool/release/3.0 and tarantool/release/2.11 branches? On 11.03.24, Maksim Kokryashkin wrote: > From: Maxim Kokryashkin > > This patch makes use of reusable workflows from the > Tarantool repository, so now LuaJIT CI tests integration > in all relevant workflows. > > Also, this patch disables MacOS testing for Tarantool > integration since those runs were made nightly in the > Tarantool repo. > > As noted in the documentation [1], it is impossible for a single > workflow call tree to include more than 20 workflows. To > overcome this limitation, workflows are started in a bunch of > separate files. This makes it impossible to depend on LuaJIT-only > jobs for integration workflows such as `tarantool-ecosystem.yml` > or `tarantool-exotic.yml` since it is impossible to make Nit: I suppose it should be " or ". > cross-dependencies between workflow files. > > --- > > Changes in v5: > - Added secrets section for integration-tarantool-ecosystem.yml to > resolve the issue with etcd-client integration. > > Branch: https://github.com/tarantool/luajit/tree/fckxorg/integration-testing > > .../integration-tarantool-ecosystem.yml | 41 ++++++ > .github/workflows/integration-tarantool.yml | 118 ++++++++++++++++++ > .github/workflows/testing.yml | 9 ++ > 3 files changed, 168 insertions(+) > create mode 100644 .github/workflows/integration-tarantool-ecosystem.yml > create mode 100644 .github/workflows/integration-tarantool.yml > > diff --git a/.github/workflows/integration-tarantool-ecosystem.yml b/.github/workflows/integration-tarantool-ecosystem.yml > new file mode 100644 > index 00000000..ccafd601 > --- /dev/null > +++ b/.github/workflows/integration-tarantool-ecosystem.yml > diff --git a/.github/workflows/integration-tarantool.yml b/.github/workflows/integration-tarantool.yml > new file mode 100644 > index 00000000..cf5c7fb5 > --- /dev/null > +++ b/.github/workflows/integration-tarantool.yml > diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml > index cb4ba57b..1581c8fc 100644 > --- a/.github/workflows/testing.yml > +++ b/.github/workflows/testing.yml > @@ -1,3 +1,11 @@ > +# XXX: A single call tree for reusable workflows can't exceed the > +# total of 20 workflows, as stated in the documentation [1]. > +# Some other jobs are started in separate workflow files to > +# overcome the limitation. The jobs are Tarantool ecosystem > +# integration testing (tarantool-ecosystem.yml) and exotic > +# Tarantool builds (tarantool-exotic.yml). Nit: I suppose it should be "integration testing of Tarantool and its ecosystem ". > +# > +# [1]: https://docs.github.com/en/actions/using-workflows/reusing-workflows#limitations > name: Testing > > on: > @@ -108,6 +116,7 @@ jobs: > -- Best regards, Sergey Kaplun