From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 73D2F96C4A9; Sun, 18 Feb 2024 14:58:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 73D2F96C4A9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1708257534; bh=vAq8KQ7ZznihjqNglSyKXRzfz+BsaBA7KOUQD5eQVuc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DNX72vnXcDylQlwk1TILIvGPJDh4j8ZDRkYrJcNY1GX4O3dA3A9aozBnB7GQfRm9V s4OB2J04SdcB/nRHs+ZjryoKQBO1c9d+It/BAnP/0khI+nr895wTKMiIoIfp4z1QMt Z6ThYwQ4LhV6qfo/Ireb5H54ahuhXW+ehIoHKl+8= Received: from smtp3.i.mail.ru (smtp3.i.mail.ru [95.163.41.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5B95596C4A9 for ; Sun, 18 Feb 2024 14:58:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B95596C4A9 Received: by smtp3.i.mail.ru with esmtpa (envelope-from ) id 1rbfoq-0000000Cm6g-2uiB; Sun, 18 Feb 2024 14:58:53 +0300 Date: Sun, 18 Feb 2024 14:54:54 +0300 To: Maxim Kokryashkin Message-ID: References: <1708256919.54066971@f115.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1708256919.54066971@f115.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9001F8F2F6BAD2021721DFC1638C0DE020CB518295F388C0600894C459B0CD1B95464116C979FBA98FE86908C20D0159679E74B05B4C870D0F80B17A5A8B94FDF4F193C0F926A29E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BAE5222749FC9020C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE73DDC6BBB7CD71318EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B73AB1701401CD8715968C9F469A3A75DA843A4CDA47601F833195AEB3E825E7AA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C2FFDA4F57982C5F42E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A514C8F931492CF3F35002B1117B3ED696D6D1C18E7355DFA5406406D89DD9EB8A823CB91A9FED034534781492E4B8EEADFCE5E68AF59B345DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFDBD9BAB1CBA85644CD3E2DE6039EFCC431714242E6C57383D08AC29B34581EF960849098BFF6585A34E84B500378195FD2BD8BFCFBA25129BEA44446A4E63BC179C92338279C818F5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3ZJ49a6yxus4B8Hme+SvPQ== X-DA7885C5: D0DB7C565EE5F35DF255D290C0D534F9E741376EE64FDEEE5C3F26B5F9504EFAE7602A4C131CB1CE5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33169A88DE2481A770DC6B747CC8D6EEA577E2E9713C15BF9CE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 00/26] More tests from LuaJIT-tests, part 1 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! On 18.02.24, Maxim Kokryashkin wrote: > > Hi, thanks for the fixup! > IINM, the LUAJIT_NO_UNWIND flag means that there is no > external unwinding, and internal unwinding is used instead, > without any additional configuration. Do we really need to add > this extra flag? This is a tag for the testing suite. As you can see, it adds the additional flag to index the file to skip. Option LUAJIT_NO_UNWIND is already used, see : | option(LUAJIT_NO_UNWIND "Disable external unwinding.") With internal unwinder, there is no interoperability with C++ ABI exceptions, so exeptions from this are not catched (predictable), and this aborts the process. >   >   > -- > Best regards, > Maxim Kokryashkin >   >   > >  > >>Hi, folks! > >> > >>I found that with disabled external unwinding, the fails > >>(predictably). The following patch fixes it (squashed it with the > >>corresponding commit). > >>=================================================================== > >>diff --git a/test/LuaJIT-tests/CMakeLists.txt b/test/LuaJIT-tests/CMakeLists.txt > >>index e91e3d4a..a0fb5440 100644 > >>--- a/test/LuaJIT-tests/CMakeLists.txt > >>+++ b/test/LuaJIT-tests/CMakeLists.txt > >>@@ -57,12 +57,19 @@ if(LUAJIT_USE_ASAN) > >>   endif() > >> endif() > >>  > >>+if(LUAJIT_NO_UNWIND) > >>+ # Test verifies the interoperability with C++ > >>+ # ABI exceptions, so it requires external unwinding enabled. > >>+ # Hence, skip them otherwise. > >>+ set(LUAJIT_TEST_TAGS_EXTRA +internal_unwinder) > >>+endif() > >>+ > >> add_custom_command(TARGET LuaJIT-tests > >>   COMMENT "Running LuaJIT-tests" > >>   COMMAND > >>     env > >>       ${LUAJIT_TESTS_ENV} > >>       ${LUAJIT_TEST_COMMAND} ${CMAKE_CURRENT_SOURCE_DIR}/test.lua > >>- +slow +ffi +bit +jit > >>+ +slow +ffi +bit +jit ${LUAJIT_TEST_TAGS_EXTRA} > >>   WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} > >> ) > >>diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index > >>index 41f7e7db..4ff7a297 100644 > >>--- a/test/LuaJIT-tests/lang/index > >>+++ b/test/LuaJIT-tests/lang/index > >>@@ -1,7 +1,7 @@ > >> andor.lua > >> api_call.lua > >> assignment.lua > >>-catch_cpp.lua > >>+catch_cpp.lua -internal_unwinder > >> catch_wrap.lua > >> compare.lua > >> compare_nan.lua > >>=================================================================== > >> > >>-- > >>Best regards, > >>Sergey Kaplun > >  -- Best regards, Sergey Kaplun