From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8C60EA1956B; Thu, 8 Feb 2024 14:28:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8C60EA1956B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707391729; bh=DWykZRmj5dBw8I/E+fQ0tibU4bBgfXCNZ/AzKITFhQY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TPKnKdc3c/55e4ZIglD3oVeXo5Qi+IzRDGG6DfUOHrbo5YtycV1LNJpJYv2jmFqWc eD1ROv26ez8Cv3NW4CfULBgIxZJeAJFp9SgfvVmeVvG2THvXwWH07xl4mfUiuiXzBx y16+aISr0b5UQuuKkXOcnKcNm2bfqa8emwf1AXug= Received: from smtp3.i.mail.ru (smtp3.i.mail.ru [95.163.41.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BF6D840E76C for ; Thu, 8 Feb 2024 14:28:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BF6D840E76C Received: by smtp3.i.mail.ru with esmtpa (envelope-from ) id 1rY2aG-0000000CUGI-0HLP; Thu, 08 Feb 2024 14:28:48 +0300 Date: Thu, 8 Feb 2024 14:24:49 +0300 To: Sergey Bronnikov Message-ID: References: <20240207145108.29786-1-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91FEFD63CE1B099162296A97A0CC14860CD7C04226BA1026C00894C459B0CD1B9D58EDBE3EE3828626740C9E0EC306CA280B260E4AF5808754027827437B59CC5F8D9167951636718 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D07BBD2EBFB7BF888638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D83166A854E8FAE94B9322AD87277CEB094A19E6967F03BDA8CC7F00164DA146DAFE8445B8C89999728AA50765F7900637D0FEED2715E18529389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735C8D5298E42E60C1FC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5BB7C7E182CBC74FF5002B1117B3ED696CFB2D894F2A4022222DFD5397F446790823CB91A9FED034534781492E4B8EEAD776A0366D588B3C3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA1C333EBB9A8564DA7FC7ED66BCCF31DA59CC5730A3B78D2E844A08C81E75826744A43F78FC6FA90766A7423F6D95CBE8BE83C3AF9012C5347B0D6B82F813BDA251CB11BEE6ADE705F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojlN/n4z3iVuT+S0oYqMGEzQ== X-DA7885C5: FA645DBB3CF3C625F255D290C0D534F934502D8A6A5819D2FCCEF2BB8CE7BD21A1B22DD8414DEABD5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33C62DC7A5781A4BF1F117C4FF0960FD5803A25701B8FBEAD2E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Consider slots used by upvalues in use-def analysis. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment and force-pushed the branch. On 08.02.24, Sergey Bronnikov wrote: > Hi, Sergey > > thanks for the patch! LGTM with a minor comment > > On 2/7/24 17:51, Sergey Kaplun wrote: > > From: Mike Pall > > > > Reported by XmiliaH. > > > > (cherry picked from commit 3a654999c6f00de4cb9e61232d23579442e544a0) > > > > `snap_usedef()` analysis doesn't check slots for child upvalues of the > > currentlly recorded function in use-def analysis. Hence, such slots may > typo: currentlly Fixed, thanks! The new commit message is the following: | Consider slots used by upvalues in use-def analysis. | | Reported by XmiliaH. | | (cherry picked from commit 3a654999c6f00de4cb9e61232d23579442e544a0) | | `snap_usedef()` analysis doesn't check slots for child upvalues of the | currently recorded function in use-def analysis. Hence, such slots may | be considered unused and not stored in the snapshot. So on snapshot | restoration, values from these slots may be lost. | | This patch adds a marking for all such local upvalues. | | Sergey Kaplun: | * added the description and the test for the problem | | Part of tarantool/tarantool#9595 > > be considered unused and not stored in the snapshot. So on snapshot > > restoration, values from these slots may be lost. > > > > This patch adds a marking for all such local upvalues. > > > > Sergey Kaplun: > > * added the description and the test for the problem > > > > Part of tarantool/tarantool#9595 > > --- -- Best regards, Sergey Kaplun