From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A1C009E9E22; Tue, 6 Feb 2024 17:25:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A1C009E9E22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707229518; bh=YI6LDFha9abywx/BaXCYlhkqVIYZRUyG5mR42gWSf9U=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p7BkgY6upSzZQBvJ/Ur38w1Sj2xLSexceu0r0JBuTQd0E3gPMloiMoj3aU3AJWx9L 9RQ/kMDhd+tuc8amVvkEISchSdiOMAyRaNkpZeqPS8EuAber/CQAfcqGtwRjKy8+DA rNNRzbwLFFqU717nNJvLdHo95Qhq5Tsdz2ZkXNpA= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 19FB89E9E22 for ; Tue, 6 Feb 2024 17:25:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 19FB89E9E22 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1rXMNv-00000007A3W-2tCm; Tue, 06 Feb 2024 17:25:16 +0300 Date: Tue, 6 Feb 2024 17:21:18 +0300 To: Maxim Kokryashkin Message-ID: References: <2a5fbe653d26a7a9d3d8d627f7345cd78ceec93a.1706520765.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51F243EDEE97DB63500C35E1C1BBCAAE16182A05F538085040A05721C6F59B8E6F91417EB218679B820EEBFF609814DA5CEB7959DB07BACED7E6CFE96EA49CC3A4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9D6DADD6B53929DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637174E2957C4CE0F938638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B8EA8BF1A1F18DD2BE3B1446728250B9088773E2CAE112D9CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8EDCF5861DED71B2F389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FCF1175FABE1C0F9B6E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BB835E6E385EA5AF075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5CBE14B40B536A8E75002B1117B3ED69617CDF2B82F03933133EE06AFCD964888823CB91A9FED034534781492E4B8EEADA333A05395E4745BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFF9C96E431EF065EBA5A9F43C69ACA60C4F8444C99E1D579F94CB1E9C7E5E52CE8926F27D50C27B5D807D692F32DC7032C4E05E876F0324517B769C757BB582A24CAD4CF88D30D2915F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnOrqvC9OB/egA== X-DA7885C5: C06DFF6E691921A5F255D290C0D534F9B8C3F74C8603912402B7E192D37BC328A9C7F521AA3D17635B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33B076B3D530863475EFE95381859F664764717F82CB60534FE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 20/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment below. On 01.02.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > On Mon, Jan 29, 2024 at 01:45:20PM +0300, Sergey Kaplun wrote: > > +do --- checkfail > More elaborate name would be nice. =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua index cc123808..c095ff46 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_cdef.lua @@ -3,7 +3,7 @@ local ffi = require("ffi") local checkfail = require("common.ffi.checkfail") local checktypes = require("common.ffi.checktypes") -do --- checkfail +do --- incorrect or unsupported declarations checkfail({ "int", "int aa1; int aa2 ", =================================================================== > > + checkfail({ > > + "int", > > + "int aa1; int aa2 ", > > + "static int x;", > > + "static const long long x = 1;", -- NYI > > + "static const double x = 1;", -- NYI > > + "static const bool x = 1;", -- NYI (intentional, need true/false) > > + "struct { static int x = 1; };", > > + ";;static int y" > > + }, ffi.cdef) > > +end > -- Best regards, Sergey Kaplun