From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1FE7B9E9E37; Tue, 6 Feb 2024 17:27:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1FE7B9E9E37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707229644; bh=olp/X2J5G/IUXF4unc/3cCj5HOsZy+P/waGCVLIs2bo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=y7EjHtA1yo/5v4zFSVo4/oNkrn6s7SN1HHi0IqQXgM8oH3UhwshSyNxcp0YAyPGiP 8F0gpv3E1e1/DuJWAIaz2vD7jQj60LAweeMsw93pEuKHsxxmK8TfQS07eDW8kr/EYk wFewbYZTqNg4X6WGEDDp2iN6KQY1xu/wapkBW2DQ= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [95.163.41.85]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 81CFE9E9E38 for ; Tue, 6 Feb 2024 17:27:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 81CFE9E9E38 Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1rXMPx-0000000783t-1KLa; Tue, 06 Feb 2024 17:27:21 +0300 Date: Tue, 6 Feb 2024 17:23:24 +0300 To: Maxim Kokryashkin Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51C23E432171C17243CB97403412A6CD80182A05F5380850405CF5F1349F14C5B591417EB218679B825269D0D85F006C7BEB7959DB07BACED7D7B80A6ED51EB853 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B9FBA884A7C9B8BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD60A286D0BA57028638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A4588E58CEEA90BCD7CA6AB5582CC79C2599C4129A16A648CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2457FAF19517CF2C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5FD0F55AE99152CB65002B1117B3ED696C167CD76E1516339250A03108B67251B823CB91A9FED034534781492E4B8EEADD8DFB5E8F7680678 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFA665970A2A06D2505DFB0A4531A4A6FEFB1FAA6E635FBFA409445DDCC131EBBAB268D298D11CBB1A807D692F32DC7032B157F3665DB1A70555CDABA4648D72A4893BBE7B23840BFC5F4332CA8FE04980913E6812662D5F2A5EAB5682573093F7837F15F2B5E4A70B33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnP7vEjYSB+UbA== X-DA7885C5: 98C7725F01607E18F255D290C0D534F9014709BC89398798F8FF2AB3E74D578FC1ACFBDE9E6D15D25B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393590D8C940224AE33D7584CCE84525591AE66E4E2A1830686A910E13C38E6CEF0E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 21/26] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the review! Fixed your comment below. On 01.02.24, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > On Mon, Jan 29, 2024 at 01:45:21PM +0300, Sergey Kaplun wrote: > > +do --- checkfail > A more elaborate name would be nice. Fixed. =================================================================== diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua index cb231c33..60385810 100644 --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_struct.lua @@ -7,7 +7,7 @@ local fails = require("common.fails") local P = ffi.sizeof("void *") local A = (ffi.arch == "x86" and not ffi.abi("win")) and 4 or 8 -do --- checkfail +do --- incorrect declarations checkfail{ "struct", "struct {", =================================================================== > > + checkfail{ > > + "struct", > > + "struct {", > > + "struct xx xx {}", > > + "struct { int x }", > > + "struct { int x, }", > > + "struct { int x,y }", > > + "struct { void x; }", > -- Best regards, Sergey Kaplun